-
-
Notifications
You must be signed in to change notification settings - Fork 0
fix(ci): unbreak workflow YAML and add a complete actions.lock #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| # SPDX-License-Identifier: MPL-2.0 | ||
| # This workflow is managed by gh actions-lock. | ||
| # This workflow is managed by gh actions-lock. | ||
| # Dormant push-email notification. ARMED by setting the repo variable | ||
| # PUSH_EMAIL_ENABLED=true (the single on/off switch). Addresses are pre-filled; | ||
| # sending needs the org SMTP secrets (SMTP_HOST/PORT/USER/PASS). Inherited by | ||
|
|
@@ -17,7 +18,7 @@ | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Send push notification email | ||
| uses: dawidd6/action-send-mail@v18 | ||
| uses: dawidd6/action-send-mail@v3.12.0 | ||
|
Check warning on line 21 in .github/workflows/push-email-notify.yml
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 HIGH RISK To ensure the action is immutable and follows the dependency locking requirements of this PR, use a full-length commit SHA instead of a version tag. This protects the workflow against supply chain attacks where a tag could be reassigned to a malicious commit. |
||
| with: | ||
| server_address: ${{ secrets.SMTP_HOST }} | ||
| server_port: ${{ secrets.SMTP_PORT }} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚪ LOW RISK
Nitpick: This line is a duplicate of the comment on line 2. It should be removed to avoid redundancy in the workflow header.