Skip to content

chore: fill or remove RSR template placeholders - #49

Merged
hyperpolymath merged 4 commits into
mainfrom
fix/rsr-placeholders
Jul 28, 2026
Merged

chore: fill or remove RSR template placeholders#49
hyperpolymath merged 4 commits into
mainfrom
fix/rsr-placeholders

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

openssf-compliance.yml fails when any of the thirteen files it checks still contains a {{PLACEHOLDER}} token. This clears them, with no invention.

  • Deleted the TEMPLATE INSTRUCTIONS (delete this block before publishing) comment — the template says to delete it, and it is where every legend line lived, so a large share of the reported tokens were the file documenting its own placeholders.
  • Filled what the repository itself supplies: owner and repo from the git remote, project name, year, forge, main branch, contact email.
  • Removed PGP and website lines. https://github.com/<user>.gpg returns HTTP 200 for every account; with no key uploaded the body is a stub reading "This user hasn't uploaded any GPG keys". No key is published for either account, and commit signing here is SSH — unrelated. The template sanctions this: "Optional: Remove sections that don't apply (e.g. PGP if you don't use it)."\n\nA security policy telling a researcher to encrypt to a key that does not exist is worse than one that does not mention encryption.\n\nWhere applicable, this also fixes a misrouted advisory URL. A previous just init copied already-filled templates out of squisher-corpus, so 51 repositories directed vulnerability reports to hyperpolymath/squisher-corpus — a repository unrelated to the code being reported, meaning the affected maintainer never saw them. Repointed from this repository's own git remote.

hyperpolymath and others added 3 commits July 26, 2026 14:46
openssf-compliance.yml fails when any of the thirteen files it checks
still contains a {{PLACEHOLDER}} token. This clears them.

Three kinds of change, no invention:

The "TEMPLATE INSTRUCTIONS (delete this block before publishing)" comment
is deleted. The template says to delete it, and it is where every legend
line lives -- so a large share of the reported tokens were the file
documenting its own placeholders, not real unfilled fields.

Tokens derivable from the repository are filled: owner and repo from the
git remote, project name, year, forge, main branch, contact email.

PGP and website lines are removed rather than filled, because nothing
true could go in them. https://github.com/<user>.gpg returns HTTP 200 for
every account; with no key uploaded the body is a stub reading "This user
hasnt uploaded any GPG keys". No key is published for either account
here, and commit signing in this estate is SSH, which is unrelated. Only
one repository in the estate has a domain, so {{WEBSITE}} likewise has no
correct value. The template sanctions this: "Optional: Remove sections
that dont apply (e.g. PGP if you dont use it)." A security policy telling
a researcher to encrypt to a key that does not exist is worse than one
that does not mention encryption.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

🔍 Hypatia Security Scan

Findings: 61 issues detected

Severity Count
🔴 Critical 1
🟠 High 21
🟡 Medium 39

⚠️ Action Required: Critical security issues found!

View findings
[
  {
    "reason": "Issue in boj-build.yml",
    "type": "missing_timeout_minutes",
    "file": "boj-build.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in casket-pages.yml",
    "type": "missing_timeout_minutes",
    "file": "casket-pages.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in casket-pages.yml",
    "type": "missing_timeout_minutes",
    "file": "casket-pages.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in codeql.yml",
    "type": "missing_timeout_minutes",
    "file": "codeql.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in dependabot-automerge.yml",
    "type": "missing_timeout_minutes",
    "file": "dependabot-automerge.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in dogfood-gate.yml",
    "type": "missing_timeout_minutes",
    "file": "dogfood-gate.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in dogfood-gate.yml",
    "type": "missing_timeout_minutes",
    "file": "dogfood-gate.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in dogfood-gate.yml",
    "type": "missing_timeout_minutes",
    "file": "dogfood-gate.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in dogfood-gate.yml",
    "type": "missing_timeout_minutes",
    "file": "dogfood-gate.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in dogfood-gate.yml",
    "type": "missing_timeout_minutes",
    "file": "dogfood-gate.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  }
]

Powered by Hypatia Neurosymbolic CI/CD Intelligence

Comment thread guix.scm
Comment thread guix.scm
Comment thread SECURITY.md
@gitar-bot

gitar-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

Note

Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime.
Learn more

CI failed: CI failures caused by a missing local path dependency (`gossamer-rs`), a missing canonical actions allowlist file in repository checks, and banned ReScript files violating governance rules.

Overview

Three distinct failures were detected across the CI jobs: a missing workspace dependency path for gossamer-rs, a governance check failure due to banned ReScript files (.res), and a configuration failure from a missing canonical actions allowlist file.

Failures

Missing Workspace Dependency gossamer-rs (confidence: high)

  • Type: dependency
  • Affected jobs: 90326722722
  • Related to change: yes
  • Root cause: The workspace dependency gossamer-rs points to an absolute path (/home/runner/work/gossamer/bindings/rust/Cargo.toml) that does not exist on the CI runner.
  • Suggested fix: Update the dependency path for gossamer-rs in Cargo.toml to use a relative path within the repository or configure CI workflows to check out the required dependency repository at the expected path.

Banned ReScript Governance Violation (confidence: high)

  • Type: tooling
  • Affected jobs: 90326444169
  • Related to change: no
  • Root cause: The repository contains ReScript files (*.res), which violate the cicd_rules/banned_language_file governance policy enforcing AffineScript instead.
  • Suggested fix: Remove or migrate the ReScript files (such as gui/src/tea/Tea_Sub.res) to AffineScript, or add a # hypatia:ignore cicd_rules/banned_language_file pragma if the files are intentionally present.

Missing Canonical Actions Allowlist (confidence: high)

  • Type: configuration
  • Affected jobs: 90326444143
  • Related to change: yes
  • Root cause: The script check-actions-policy.sh expects the canonical allowlist (rhodium-standard-repositories/actions-allowlist/allowed-actions.json), which is missing or not checked out properly in the workflow environment.
  • Suggested fix: Ensure that the standards repository or actions allowlist submodule/dependency is properly checked out or included in the workflow before running the actions policy check.

Summary

  • Change-related failures: 2 failures related to missing dependency configuration (gossamer-rs) and missing standards/allowlist checkouts.
  • Infrastructure/flaky failures: 0 infrastructure or flaky failures.
  • Recommended action: Fix the gossamer-rs workspace dependency reference, ensure the standards repository submodule/dependency is checked out for actions policy validation, and resolve or ignore the banned ReScript files.
Code Review ✅ Approved 3 resolved / 3 findings

Fills RSR template placeholders and updates guix.scm, but the license constructor is called with insufficient arguments, the package name conflicts with the repository name, and SECURITY.md retains an unset PGP fingerprint.

✅ 3 resolved
Bug: guix.scm names package 'squisher-corpus' inside intsoc-transactor repo

📄 guix.scm:2 📄 guix.scm:10 📄 guix.scm:14 📄 guix.scm:15 📄 guix.scm:16
This repository's git remote is hyperpolymath/intsoc-transactor, but guix.scm sets name, synopsis, description and home-page all to squisher-corpus (the file header even says "GNU Guix package definition for squisher-corpus"). This is exactly the squisher-corpus misrouting the PR claims to fix, reintroduced here — the package will build/publish under the wrong identity and point users to an unrelated repo. Repoint every field to intsoc-transactor.

Bug: guix.scm license constructor called with 2 of 3 required args

📄 guix.scm:17-18
The private license record constructor in (guix licenses) requires three positional arguments (name, uri, comment), but line 17-18 passes only two ("PMPL-1.0-or-later" and the URL). Loading this file with guix shell -f guix.scm raises a wrong-number-of-arguments error, so the package definition cannot be evaluated. Add the missing comment argument, e.g. ((@@ (guix licenses) license) "PMPL-1.0-or-later" "https://github.com/hyperpolymath/palimpsest-license" "Palimpsest MPL").

Quality: SECURITY.md still tells reporters to use unset PGP fingerprint

📄 SECURITY.md:41-45
The PR summary argues that directing researchers to a nonexistent key is worse than omitting encryption, yet SECURITY.md line 44 retains **Fingerprint** | \[PGP fingerprint not set]`` under "Alternative: Encrypted Email". This contradicts the stated intent and instructs reporters to encrypt to a key that does not exist. Remove the fingerprint row (or the encrypted-email subsection) to match the PR's rationale.

Tip

Comment Gitar fix CI to trigger a fix.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@hyperpolymath
hyperpolymath merged commit dd413fe into main Jul 28, 2026
19 of 22 checks passed
@hyperpolymath
hyperpolymath deleted the fix/rsr-placeholders branch July 28, 2026 16:19
@github-actions

Copy link
Copy Markdown

🔍 Hypatia Security Scan

Findings: 61 issues detected

Severity Count
🔴 Critical 1
🟠 High 21
🟡 Medium 39

⚠️ Action Required: Critical security issues found!

View findings
[
  {
    "reason": "Issue in boj-build.yml",
    "type": "missing_timeout_minutes",
    "file": "boj-build.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in casket-pages.yml",
    "type": "missing_timeout_minutes",
    "file": "casket-pages.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in casket-pages.yml",
    "type": "missing_timeout_minutes",
    "file": "casket-pages.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in codeql.yml",
    "type": "missing_timeout_minutes",
    "file": "codeql.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in dependabot-automerge.yml",
    "type": "missing_timeout_minutes",
    "file": "dependabot-automerge.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in dogfood-gate.yml",
    "type": "missing_timeout_minutes",
    "file": "dogfood-gate.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in dogfood-gate.yml",
    "type": "missing_timeout_minutes",
    "file": "dogfood-gate.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in dogfood-gate.yml",
    "type": "missing_timeout_minutes",
    "file": "dogfood-gate.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in dogfood-gate.yml",
    "type": "missing_timeout_minutes",
    "file": "dogfood-gate.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in dogfood-gate.yml",
    "type": "missing_timeout_minutes",
    "file": "dogfood-gate.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  }
]

Powered by Hypatia Neurosymbolic CI/CD Intelligence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant