fix(ci): unbreak workflow YAML and add a complete actions.lock - #49
Conversation
Remediates GitHub Workflow Dependency Locking (public preview), which rejects runs at startup_failure with zero jobs and no logs. See hyperpolymath/standards#657. Five steps, in order, because each blocks the next: 1. Unbroke any workflow whose `permissions:` carried a scalar with an indented mapping under it - blind-permissions-insertion damage. This matters beyond the one file: gh actions-lock refuses to run when ANY workflow in the repo fails to parse, so the repo could never acquire a lockfile and could never self-heal. 2. Repinned hyperpolymath/standards reusables off commits that have no actions.lock. The rejection requires the CALLEE to be covered at the pinned SHA, which is unsatisfiable at a pre-lockfile commit. 3. Generated the lockfile with gh actions-lock. 4. Hand-added the reusable-workflow caller entries the tool omits, as '<path>': []. Measured across 218 repos: P(startup_failure | has lockfile) = 91.7% vs 15.8% without, because every workflow a lockfile OMITS is rejected. A PARTIAL lock is worse than none - running gh actions-lock and stopping there is how this outage spread. 5. Restored SPDX-License-Identifier to line 1, which the tool displaces with its own banner and which the workflow-security linter greps with head -1. Verified before push: 0 unparseable workflows, lockfile covers every workflow with no omissions, SPDX on line 1 in every file. Proven on hyperpolymath/anamnesis: 6 of 6 workflows dead -> 0 startup_failure, 13 running. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 1 high |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
The pull request is currently not up to standards according to quality analysis. While the intent is to remediate GitHub Workflow dependency locking and fix syntax errors, the implementation is incomplete. Crucially, the actions.lock file is missing from the submission, and the specific YAML parsing errors described in the PR intent are not visible in the provided changes. Additionally, there is a security regression across multiple files where immutable commit SHAs have been replaced with mutable version tags, which reduces supply-chain security visibility and contradicts best practices for pinned environments.
About this PR
- There is a systemic transition from immutable commit SHAs to mutable version tags (e.g., in
codeql.ymlandpush-email-notify.yml). This reduces the security posture of the CI pipeline by introducing vulnerability to tag-switching or supply-chain attacks. - The
actions.lockfile, which is a primary objective of this PR, is missing from the submitted changes. This file is necessary to verify the dependency locking implementation. - The YAML syntax remediation (fixing invalid mappings under scalars in 'permissions') could not be verified. Ensure all intended 'unbreak' changes are included in the commit.
Test suggestions
- Verify that 'SPDX-License-Identifier' is preserved on line 1 in all modified workflows.
- Verify that 'Secret Scanner' and other workflows are pinned to specific commits or versions as required by the locking strategy.
- Verify the 'actions.lock' file exists in '.github/workflows/' and contains entries for all workflows.
- Verify that 'actions: read' permission is added to workflows that previously lacked it (e.g., Secret Scanner).
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify the 'actions.lock' file exists in '.github/workflows/' and contains entries for all workflows.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback




Remediates GitHub Workflow Dependency Locking (public preview, no changelog entry), which rejects runs at
startup_failure— zero jobs, no logs, nothing in REST or GraphQL. Full analysis:hyperpolymath/standards#657.Proven on
hyperpolymath/anamnesis: 6 of 6 workflows dead → 0startup_failure, 13 running.Five steps, in order — each blocks the next
1. Unbreak the workflow YAML. Any
permissions:carrying a scalar with an indented mapping under it:This reaches past the one file:
gh actions-lockrefuses to run when any workflow in the repo fails to parse, so the repo can never acquire a lockfile and can never self-heal.2. Repin
standardsreusables off commits with noactions.lock. The rejection requires the callee to be covered at the pinned SHA — unsatisfiable at a pre-lockfile commit.3. Generate the lockfile with
gh actions-lock.4. Hand-add the reusable-caller entries the tool omits, as
'<path>': [].P(startup_failure | has lockfile) = 91.7%vs15.8%without — because every workflow a lockfile omits is rejected. A partial lock is worse than none. Runninggh actions-lockand stopping there is how this outage spread.5. Restore
SPDX-License-Identifierto line 1, which the tool displaces with its own banner and which the workflow-security linter greps viahead -1.Verified before this PR was opened
0unparseable workflows · lockfile covers every workflow, no omissions · SPDX on line 1 in every file. The script refuses to push if any of the three fails.🤖 Generated with Claude Code