Skip to content

chore: fill or remove RSR template placeholders - #43

Merged
hyperpolymath merged 3 commits into
mainfrom
fix/rsr-placeholders
Jul 28, 2026
Merged

chore: fill or remove RSR template placeholders#43
hyperpolymath merged 3 commits into
mainfrom
fix/rsr-placeholders

Conversation

@hyperpolymath

@hyperpolymath hyperpolymath commented Jul 28, 2026

Copy link
Copy Markdown
Owner

openssf-compliance.yml fails when any of the thirteen files it checks still contains a {{PLACEHOLDER}} token. This clears them, with no invention.

  • Deleted the TEMPLATE INSTRUCTIONS (delete this block before publishing) comment — the template says to delete it, and it is where every legend line lived, so a large share of the reported tokens were the file documenting its own placeholders.
  • Filled what the repository itself supplies: owner and repo from the git remote, project name, year, forge, main branch, contact email.
  • Removed PGP and website lines. https://github.com/<user>.gpg returns HTTP 200 for every account; with no key uploaded the body is a stub reading "This user hasn't uploaded any GPG keys". No key is published for either account, and commit signing here is SSH — unrelated. The template sanctions this: "Optional: Remove sections that don't apply (e.g. PGP if you don't use it)."\n\nA security policy telling a researcher to encrypt to a key that does not exist is worse than one that does not mention encryption.\n\nWhere applicable, this also fixes a misrouted advisory URL. A previous just init copied already-filled templates out of squisher-corpus, so 51 repositories directed vulnerability reports to hyperpolymath/squisher-corpus — a repository unrelated to the code being reported, meaning the affected maintainer never saw them. Repointed from this repository's own git remote.

Summary by Gitar

  • CI Workflows:
    • Added actions: read permission block to workflow files for estate-wide security compliance

This will update automatically on new commits.

hyperpolymath and others added 2 commits July 26, 2026 14:43
openssf-compliance.yml fails when any of the thirteen files it checks
still contains a {{PLACEHOLDER}} token. This clears them.

Three kinds of change, no invention:

The "TEMPLATE INSTRUCTIONS (delete this block before publishing)" comment
is deleted. The template says to delete it, and it is where every legend
line lives -- so a large share of the reported tokens were the file
documenting its own placeholders, not real unfilled fields.

Tokens derivable from the repository are filled: owner and repo from the
git remote, project name, year, forge, main branch, contact email.

PGP and website lines are removed rather than filled, because nothing
true could go in them. https://github.com/<user>.gpg returns HTTP 200 for
every account; with no key uploaded the body is a stub reading "This user
hasnt uploaded any GPG keys". No key is published for either account
here, and commit signing in this estate is SSH, which is unrelated. Only
one repository in the estate has a domain, so {{WEBSITE}} likewise has no
correct value. The template sanctions this: "Optional: Remove sections
that dont apply (e.g. PGP if you dont use it)." A security policy telling
a researcher to encrypt to a key that does not exist is worse than one
that does not mention encryption.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
Comment thread SECURITY.md
@gitar-bot

gitar-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

Note

Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime.
Learn more

CI failed: CI failed due to a governance violation from banned ReScript files and a missing local path dependency (`gossamer-rs`) in Cargo.toml.

Overview

Two distinct failures occurred across the CI jobs: a repository governance check violation flagging banned ReScript files, and a Cargo dependency resolution failure looking for a local path dependency gossamer-rs.

Failures

Governance Check: Banned ReScript Files (confidence: high)

  • Type: build
  • Affected jobs: 90326142609
  • Related to change: yes
  • Root cause: The repository governance rule cicd_rules/banned_language_file flagged ReScript files (such as src/proven/Proven_SafePath.res) which are banned in favor of AffineScript.
  • Suggested fix: Migrate the ReScript files to AffineScript, or declare an appropriate exemption via .hypatia-ignore or an inline pragma (/* # hypatia:ignore cicd_rules/banned_language_file */).

Cargo Missing Local Path Dependency (confidence: high)

  • Type: dependency
  • Affected jobs: 90326357978
  • Related to change: unclear
  • Root cause: Cargo failed to resolve the local path dependency gossamer-rs because the expected directory (../gossamer/bindings/rust/) does not exist in the CI environment.
  • Suggested fix: Ensure the required dependency repository is checked out in CI alongside this repository, update the path in Cargo.toml, or switch to a published registry dependency.

Summary

  • Change-related failures: 1 governance check failure due to banned ReScript files introduced/present in the PR.
  • Infrastructure/flaky failures: 0
  • Recommended action: Remove or migrate the banned ReScript files (or add exemptions), and fix the local path dependency configuration in Cargo.toml so Cargo can resolve gossamer-rs successfully.
Code Review ✅ Approved 1 resolved / 1 findings

Fills and removes RSR template placeholders to satisfy OpenSSF compliance checks while correcting advisory URLs. Consider removing the leftover PGP fingerprint placeholder row in the email section.

Auto-approved and auto-merge armed: No blocking issues found.
Please see Auto-approve Docs for details on setting custom approval criteria. — merges when pipeline and required approvals pass.

✅ 1 resolved
Quality: Leftover PGP fingerprint placeholder in email section

📄 SECURITY.md:41-44
The PGP key URL line and the gpg code block were removed, but the row | **Fingerprint** | [PGP fingerprint not set] | remains in the "Alternative: Encrypted Email" section. This leaves an orphaned, unfilled placeholder that contradicts the PR's stated intent to stop directing researchers toward a nonexistent PGP key. Remove the Fingerprint row (and the now-single-column table if only Email remains) to fully drop PGP references.

Tip

Comment Gitar fix CI to trigger a fix.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@gitar-bot

gitar-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

⚠️ Gitar auto-approved this PR but could not enable auto-merge: auto-merge is disabled for this repository — enable "Allow auto-merge" in the repository settings.

@gitar-bot gitar-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitar has auto-approved this PR and enabled auto-merge (configure)

@gitar-bot gitar-bot Bot added the gitar-approved Added by Gitar label Jul 28, 2026
@hyperpolymath
hyperpolymath merged commit b1bdccb into main Jul 28, 2026
20 of 22 checks passed
@hyperpolymath
hyperpolymath deleted the fix/rsr-placeholders branch July 28, 2026 16:56
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gitar-approved Added by Gitar

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant