-
-
Notifications
You must be signed in to change notification settings - Fork 0
fix(ci): unbreak workflow YAML and add a complete actions.lock #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -1,5 +1,6 @@ | ||||
| # SPDX-License-Identifier: MPL-2.0 | ||||
| # This workflow is managed by gh actions-lock. | ||||
| # This workflow is managed by gh actions-lock. | ||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ⚪ LOW RISK Nitpick: Redundant header comment. This line duplicates the existing management banner on line 2.
Suggested change
|
||||
| name: Governance | ||||
|
|
||||
| on: | ||||
|
|
||||
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -1,5 +1,6 @@ | ||||
| # SPDX-License-Identifier: MPL-2.0 | ||||
| # This workflow is managed by gh actions-lock. | ||||
| # This workflow is managed by gh actions-lock. | ||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ⚪ LOW RISK Nitpick: Redundant header comment. This line duplicates the existing management banner on line 2.
Suggested change
|
||||
| name: Hypatia Security Scan | ||||
|
|
||||
| on: | ||||
|
|
||||
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -1,5 +1,6 @@ | ||||
| # SPDX-License-Identifier: MPL-2.0 | ||||
| # This workflow is managed by gh actions-lock. | ||||
| # This workflow is managed by gh actions-lock. | ||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ⚪ LOW RISK Nitpick: This line appears to be a redundant duplication of the comment on line 2. This is likely an artifact of the tool used to pin dependencies.
Suggested change
|
||||
| # Dormant push-email notification. ARMED by setting the repo variable | ||||
| # PUSH_EMAIL_ENABLED=true (the single on/off switch). Addresses are pre-filled; | ||||
| # sending needs the org SMTP secrets (SMTP_HOST/PORT/USER/PASS). Inherited by | ||||
|
|
||||
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -1,5 +1,6 @@ | ||||
| # SPDX-License-Identifier: MPL-2.0 | ||||
| # This workflow is managed by gh actions-lock. | ||||
| # This workflow is managed by gh actions-lock. | ||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ⚪ LOW RISK Nitpick: Redundant header comment. This line duplicates the existing management banner on line 2.
Suggested change
|
||||
| # Calls the estate's shared secret scanner (gitleaks + rust-secrets + | ||||
| # shell-secrets). Added because this repository had NO leak scanning at all. | ||||
| # | ||||
|
|
||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚪ LOW RISK
Nitpick: This line is a redundant duplication of the header on line 2: '# This workflow is managed by gh actions-lock.'. Removing this will maintain cleaner workflow files.