Skip to content

fix(ci): the invisible-character gate never matched anything #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperpolymath merged 2 commits into from
Aug 28, 2026
Merged

fix(ci): the invisible-character gate never matched anything #97

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c7c2cb
fix(ci): the invisible-character gate never matched anything
hyperpolymath Aug 27, 2026
f846e03
fix(ci): enforce C0/NUL corruption in-step; warn on invisible Unicode
hyperpolymath Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 30 additions & 2 deletions .github/workflows/dogfood-gate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ jobs:
# Checks for: zero-width spaces, zero-width joiners, BOM, soft hyphens,
# non-breaking spaces, null bytes, and other invisible Unicode in source files.
set +e
PATTERNS='\xc2\xa0|\xe2\x80\x8b|\xe2\x80\x8c|\xe2\x80\x8d|\xef\xbb\xbf|\xc2\xad|\xe2\x80\x8e|\xe2\x80\x8f|\xe2\x80\xaa|\xe2\x80\xab|\xe2\x80\xac|\xe2\x80\xad|\xe2\x80\xae|\x00'
PATTERNS='\x00|[\x01-\x08\x0B\x0C\x0E-\x1F]|\x{a0}|\x{ad}|\x{200b}|\x{200c}|\x{200d}|\x{200e}|\x{200f}|\x{202a}|\x{202b}|\x{202c}|\x{202d}|\x{202e}|\x{2060}|\x{feff}'

@codacy-production codacy-production Bot Aug 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 HIGH RISK

The PCRE engine requires UTF-8 mode to handle codepoints above \xff (like \x{a0}). Without this, grep will encounter a 'character value in \x{...} sequence is too large' error and fail. Since stderr is redirected, the gate will silently succeed without scanning.

Suggested change
PATTERNS='\x00|[\x01-\x08\x0B\x0C\x0E-\x1F]|\x{a0}|\x{ad}|\x{200b}|\x{200c}|\x{200d}|\x{200e}|\x{200f}|\x{202a}|\x{202b}|\x{202c}|\x{202d}|\x{202e}|\x{2060}|\x{feff}'
PATTERNS='(*UTF)\x00|[\x01-\x08\x0B\x0C\x0E-\x1F]|\x{a0}|\x{ad}|\x{200b}|\x{200c}|\x{200d}|\x{200e}|\x{200f}|\x{202a}|\x{202b}|\x{202c}|\x{202d}|\x{202e}|\x{2060}|\x{feff}'

Comment thread
coderabbitai[bot] marked this conversation as resolved.
find "$GITHUB_WORKSPACE" \
-not -path '*/.git/*' -not -path '*/node_modules/*' \
-not -path '*/.deno/*' -not -path '*/target/*' \
Expand All @@ -120,7 +120,7 @@ jobs:
-o -name '*.yml' -o -name '*.yaml' -o -name '*.md' -o -name '*.adoc' \
-o -name '*.idr' -o -name '*.zig' -o -name '*.v' -o -name '*.jl' \
-o -name '*.gleam' -o -name '*.hs' -o -name '*.ml' -o -name '*.sh' \) \
-exec grep -Prl "$PATTERNS" {} \; > /tmp/empty-lint-results.txt 2>/dev/null
-exec grep -aPrl "$PATTERNS" {} \; > /tmp/empty-lint-results.txt 2>/dev/null

@codacy-production codacy-production Bot Aug 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM RISK

Suggestion: Improve efficiency and visibility by batching files with + instead of \; (which avoids spawning a new process for every file), ensuring a UTF-8 locale for consistent matching, and removing the silent error redirection to ensure regex failures are logged.

Suggested change
-exec grep -aPrl "$PATTERNS" {} \; > /tmp/empty-lint-results.txt 2>/dev/null
-exec LC_ALL=C.UTF-8 grep -aPl "$PATTERNS" {} + > /tmp/empty-lint-results.txt

EL_EXIT=$?
set -e

Expand All @@ -129,12 +129,40 @@ jobs:
echo "exit_code=$EL_EXIT" >> "$GITHUB_OUTPUT"
echo "ready=true" >> "$GITHUB_OUTPUT"

# Blocking subset: C0 controls and NUL only (owner ruling 2026-08-28).
# Invisible Unicode (NBSP/BOM/zero-width) stays ADVISORY - about 2,100
# estate files carry it as legitimate typography in prose.
blocking=0
while IFS= read -r bf; do
[ -z "$bf" ] && continue
if grep -qaP '\x00|[\x01-\x08\x0B\x0C\x0E-\x1F]' "$bf"; then
blocking=$((blocking+1))
echo "::error file=${bf#$GITHUB_WORKSPACE/}::C0 control characters or NUL bytes - file corruption, blocks the gate"
fi
done < /tmp/empty-lint-results.txt
echo "blocking=$blocking" >> "$GITHUB_OUTPUT"

# Emit annotations for each file with invisible chars
while IFS= read -r filepath; do
[ -z "$filepath" ] && continue
REL_PATH="${filepath#$GITHUB_WORKSPACE/}"
echo "::warning file=${REL_PATH}::Invisible Unicode characters detected (zero-width space, BOM, NBSP, etc.)"
done < /tmp/empty-lint-results.txt

# Enforce (owner ruling 2026-08-28): C0/NUL corruption BLOCKS; other
# invisible Unicode stays advisory. Enforcement lives inside this step
# so a crash above fails the job directly - counts can never arrive
# empty into a separate check that then passes silently.
if [ "$EL_EXIT" -ne 0 ]; then
echo "::warning::invisible-character scan exited $EL_EXIT - results may be incomplete"
fi
if [ "${blocking:-0}" -gt 0 ]; then
echo "## Empty-linter: BLOCKED - $blocking file(s) with C0/NUL corruption" >> "$GITHUB_STEP_SUMMARY"
echo "::error::$blocking file(s) contain C0 control characters or NUL bytes - corruption, not typography. See file annotations."
exit 1
elif [ "${FINDINGS:-0}" -gt 0 ]; then
echo "::notice::$FINDINGS file(s) carry invisible Unicode (NBSP/BOM/zero-width) - advisory only"
fi
- name: Write summary
run: |
if [ "${{ steps.lint.outputs.ready }}" = "true" ]; then
Expand Down
Loading