fix: AGENTIC licence line + a2ml-validate-action repin - #53
Conversation
…, #669) 1. The AGENTIC.a2ml agent-constraint line "Never use AGPL license (...)" contradicts LICENCE-POLICY.adoc Rules 3 (co-developed), 4 (network services) and 5 (games), which MANDATE AGPL-3.0-or-later - and 144 copies named the retired PMPL-1.0-or-later. Replaced with a pointer to the policy plus the A2 no-automated-licence-edits rule, hardcoding no licence so it cannot go stale again. Same wording as the template fix in rsr-template-repo#45; owner-ruled sweep (2026-08-27). 2. Any workflow pinning hyperpolymath/a2ml-validate-action at 59145c7d or e558e79200 is repinned to 6ac6416f. Those two SHAs never existed: the repo itself was only created 2026-08-28 and populated by subtree split from a2ml/actions/validate (286 files, history preserved). The old pins could never resolve and made lockfile generation impossible. Direct push per owner ruling of 2026-08-28. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Up to standards ✅🟢 Issues
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe agent constraints now prohibit relicensing and automated licence sweeps. They require the licence policy to be read and define defaults for code, prose, and specified AGPL cases. ChangesLicence guidance
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
While the PR addresses the update to licensing instructions, there is a significant discrepancy between the intent and the implementation. The PR title and description claim to repin the a2ml-validate-action, yet no changes to workflow files or action versions are present in the code diff. This indicates a core acceptance criterion has not been met.
Additionally, the licensing instruction updates contain a path inconsistency and an ambiguity regarding Rule 2. Rule 2 lacks a specific SPDX identifier, which prevents automated agents from fulfilling the 'SPDX from birth' requirement. Although Codacy analysis indicates the current changes are up to standards, these implementation gaps and logic issues should be resolved.
About this PR
- The PR title and description specify a repin for 'a2ml-validate-action' to fix commit references, but the current diff does not contain any changes to GitHub Action versions or workflow files. Please ensure all intended changes are staged and committed.
2 comments outside of the diff
[REDACTED:HIGH_ENTROPY]
line 25⚪ LOW RISK
Nitpick: The path to the license policy document is inconsistent. Use 'standards/LICENCE-POLICY.adoc' to match the reference on the following line.
line 29🟡 MEDIUM RISK
The instruction for Rule 2 is ambiguous for an automated agent. While other rules specify SPDX identifiers (e.g., MPL-2.0, AGPL-3.0-or-later), Rule 2 only mentions it 'names the PMPL register'. This makes it difficult for an agent to fulfill the 'SPDX from birth' requirement on line 25. Please specify the exact SPDX identifier for Rule 2 or provide a clear procedure for the agent to determine the correct header.
Test suggestions
- Verify that the licensing instructions accurately summarize Rules 1-5 of the referenced LICENCE-POLICY.adoc.
- Confirm that the a2ml-validate-action repository reference is updated to a valid commit SHA.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that the licensing instructions accurately summarize Rules 1-5 of the referenced LICENCE-POLICY.adoc.
2. Confirm that the a2ml-validate-action repository reference is updated to a valid commit SHA.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
1 participant
Ruleset refused a direct push, so this lands by PR. Two mechanical fixes, owner-ruled:
Never use AGPL license (…)contradictsLICENCE-POLICY.adocRules 3/4/5 (which mandate AGPL for their scopes). Replaced with the policy pointer used inrsr-template-repo#45. Seestandards#646.a2ml-validate-actionrepin — the previously-pinned SHAs never existed; the repo was only created 2026-08-28 (split froma2ml/actions/validate, history preserved). Repinned to its real HEAD. Seestandards#669.🤖 Generated with Claude Code