Skip to content

fix(tests): terminate find -exec and pass {} — the placeholder step was a no-op #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hyperpolymath wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(tests): terminate find -exec and pass {} — the placeholder step was a no-op #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/e2e/template_instantiation_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ find "$TEST_REPO_PATH" -type f \
sed -i "s|$placeholder|$value|g" "$file"
fi
done
' _ "$file"
' _ {} \;
Comment on lines 137 to +140

@codacy-production codacy-production Bot Aug 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 HIGH RISK

The substitution logic is still a no-op. Because the subshell string is single-quoted, the parent shell's $placeholder and $value variables are not expanded. Within the subshell, you must use "$1" to refer to the file path passed by find, as $file is undefined. Recommendation: Pass the variables as arguments to the subshell (e.g., sh -c '...' _ "$placeholder" "$value" "{}") or use double quotes with appropriate escaping. Additionally, using '+' instead of ';' would be more efficient for large file sets.


log_pass "All placeholder tokens replaced"

Expand Down
Loading