Skip to content

chore: fill derivable placeholders, drop false ARCHITECTURE, surface the rest - #37

Closed
hyperpolymath wants to merge 3 commits into
mainfrom
chore/estate-topup
Closed

chore: fill derivable placeholders, drop false ARCHITECTURE, surface the rest#37
hyperpolymath wants to merge 3 commits into
mainfrom
chore/estate-topup

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Automated estate top-up. Nothing here invents a value.

Filled — every token with one mechanical answer (owner, repo, forge, author, dates, project name, main branch). Identity from the git remote, dates from the clock, name from the README H1.

Not filled, on purposeSECURITY_EMAIL (two competing addresses exist in the estate), RESPONSE_TIME, CONDUCT_TEAM (substitutes into "a {{CONDUCT_TEAM}} member", which is not English), WEBSITE, PROJECT_DESCRIPTION, LANG_STACK. More than one defensible answer exists, and a confident wrong value is worse than a visible gap.

DeletedARCHITECTURE.md where it is byte-identical to the 346-copy estate boilerplate (blob 607e3d8c). Those 33 lines describe a src/ tests/ docs/ scripts/ config/ tree this repo does not have. Matched by hash, so a genuinely written ARCHITECTURE can never be caught by it.

CODEOWNERS — the solo form from standards/CODEOWNERS-POLICY.adoc Rule 1, which forbids a catch-all where the only owner is the sole maintainer. templates/CODEOWNERS contradicts that policy; the policy is versioned, dated and resolves standards#55, so it wins. Genuine co-owners (Rule 2) are untouched.

SurfacedREQUIRES_INITIALISATION.md plus a priority action in 0-AI-MANIFEST.a2ml, listing every remaining token, what it means, which files it belongs in, why it was not done already, and that it is to be deleted only when the work is genuinely complete.

Built from a fresh clone of origin/main, never a local checkout — several of those are dirty and hold unpushed commits.

🤖 Generated with Claude Code

…the rest

Estate top-up pass. Three separate things, none of which invents a value.

FILLED — every token with a single mechanical answer: OWNER, REPO, FORGE,
PROJECT, PACKAGE_NAME, PROJECT_NAME, AUTHOR, AUTHOR_EMAIL, CONDUCT_EMAIL,
AUTHOR_FIRST/LAST/INITIALS, CURRENT_YEAR, CURRENT_DATE, DATE, MAIN_BRANCH.
Identity comes from the git remote, dates from the clock, project name from the
README H1 where there is one.

Deliberately NOT filled, because more than one defensible answer exists and a
confident wrong value is worse than a visible gap: SECURITY_EMAIL (two competing
addresses are in use across the estate), RESPONSE_TIME, CONDUCT_TEAM (which
substitutes into "a {{CONDUCT_TEAM}} member", not English), WEBSITE,
PROJECT_DESCRIPTION, LANG_STACK.

DELETED — ARCHITECTURE.md, where it is byte-identical to the 346-copy estate
boilerplate (blob 607e3d8). Those 33 lines describe a src/ tests/ docs/
scripts/ config/ tree that this repo does not have, so the file is not merely
uninformative, it is wrong. Genuinely written ARCHITECTURE files are matched by
hash and left alone. No file beats a confidently false one.

CODEOWNERS — rewritten to the solo form mandated by
hyperpolymath/standards CODEOWNERS-POLICY.adoc Rule 1, which forbids a catch-all
line where the only owner is the sole maintainer. The estate's own
templates/CODEOWNERS contradicts that policy; the policy is versioned, dated and
resolves standards#55, so it wins. Files naming a genuine co-owner are Rule 2
and are untouched. Note @hyperpolymath and @metadatastician are the same person,
so a file naming the other account is a copy artifact that silently routed
review requests to the wrong account.

SURFACED — REQUIRES_INITIALISATION.md, and a priority action in
0-AI-MANIFEST.a2ml. Tokens that need a decision no script can make are left
visibly unfilled rather than faked or quietly deleted. The marker says what each
one is, which files it belongs in, why it was not done already, and that it must
be deleted only once the work is genuinely finished.
title = {{{PROJECT_NAME}}},
year = {{{CURRENT_YEAR}}},
url = {https://github.com/{{OWNER}}/{{PROJECT_NAME}}},
@software{cicd-squabbler — an intelligent, detachable CI/CD fighter_2026,

@gitar-bot gitar-bot Bot Aug 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Bug: PROJECT_NAME long name substituted into URLs/tags/paths, breaking them

The descriptive {{PROJECT_NAME}} value ("cicd-squabbler — an intelligent, detachable CI/CD fighter") was mechanically substituted into slots that require the repo slug, producing broken output. In docs/attribution/CITATIONS.adoc the BibTeX cite key becomes @software{cicd-squabbler — an intelligent, detachable CI/CD fighter_2026 (spaces/em-dash are illegal in BibTeX keys) and every citation URL becomes https://github.com/hyperpolymath/cicd-squabbler — an intelligent, detachable CI/CD fighter, which is not a resolvable URL. In .devcontainer/Containerfile the WORKDIR becomes a path containing spaces and an em-dash, and the build-command comment yields an invalid image tag. These slots should use the repo slug cicd-squabbler (i.e. the template should have used {{REPO}}/a slug token, not {{PROJECT_NAME}}). Fix by replacing the descriptive string with cicd-squabbler in the URL/key/WORKDIR/tag positions.

Was this helpful? React with 👍 / 👎


[methodology.state-validation]
reject-if-contains = ["{{PLACEHOLDER}}", "{{PROJECT}}", "rsr-template-repo"]
reject-if-contains = ["{{PLACEHOLDER}}", "CICD_SQUABBLER", "rsr-template-repo"]

@gitar-bot gitar-bot Bot Aug 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Bug: state-validation reject list now rejects the project's own name

In .machine_readable/bot_directives/methodology.a2ml the reject-if-contains list previously held the placeholder token {{PROJECT}} so validation could detect an un-substituted, corrupt/template state file. The top-up pass replaced that token with the filled value CICD_SQUABBLER, inverting the rule's intent: legitimate state files that reference the project's own FFI namespace CICD_SQUABBLER (used in src/interface/ffi/src/main.zig, tests, and docs) will now be flagged as corrupt/template/stale and rejected. This token should have been excluded from substitution. Restore the placeholder marker so the guard again detects unfilled state, e.g. keep {{PROJECT}} (or use a distinct sentinel) rather than the resolved project name.

Keep the placeholder token in the reject list; it is a corruption sentinel, not a value to substitute.:

reject-if-contains = ["{{PLACEHOLDER}}", "{{PROJECT}}", "rsr-template-repo"]

Was this helpful? React with 👍 / 👎

@gitar-bot gitar-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR is blocked due to unresolved code review findings.

Configure merge blocking · Maintainers can dismiss this review.

@gitar-bot

gitar-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

Note

Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime.
Learn more

Code Review ⚠️ Changes requested 0 resolved / 2 findings

Automated estate top-up fills derivable placeholders and removes boilerplate architecture files, but the descriptive project name breaks URL slots and causes state validation to reject the repository's own name.

⚠️ Bug: PROJECT_NAME long name substituted into URLs/tags/paths, breaking them

📄 docs/attribution/CITATIONS.adoc:10 📄 docs/attribution/CITATIONS.adoc:14 📄 docs/attribution/CITATIONS.adoc:21 📄 docs/attribution/CITATIONS.adoc:25 📄 docs/attribution/CITATIONS.adoc:29 📄 docs/attribution/CITATIONS.adoc:33 📄 .devcontainer/Containerfile:6 📄 .devcontainer/Containerfile:29

The descriptive {{PROJECT_NAME}} value ("cicd-squabbler — an intelligent, detachable CI/CD fighter") was mechanically substituted into slots that require the repo slug, producing broken output. In docs/attribution/CITATIONS.adoc the BibTeX cite key becomes @software{cicd-squabbler — an intelligent, detachable CI/CD fighter_2026 (spaces/em-dash are illegal in BibTeX keys) and every citation URL becomes https://github.com/hyperpolymath/cicd-squabbler — an intelligent, detachable CI/CD fighter, which is not a resolvable URL. In .devcontainer/Containerfile the WORKDIR becomes a path containing spaces and an em-dash, and the build-command comment yields an invalid image tag. These slots should use the repo slug cicd-squabbler (i.e. the template should have used {{REPO}}/a slug token, not {{PROJECT_NAME}}). Fix by replacing the descriptive string with cicd-squabbler in the URL/key/WORKDIR/tag positions.

Use the repo slug in the URL and a space-free BibTeX cite key (apply the same slug to the Harvard/OSCOLA/MLA/APA URLs).
@software{cicd_squabbler_2026,
  author = {Jewell, Jonathan},
  title = {cicd-squabbler — an intelligent, detachable CI/CD fighter},
  year = {2026},
  url = {https://github.com/hyperpolymath/cicd-squabbler},
  license = {MPL-2.0}
}
Use the repo slug for the image tag and WORKDIR so the path has no spaces and matches devcontainer.json.
# Build: podman build -t cicd-squabbler-dev -f .devcontainer/Containerfile .
...
WORKDIR /workspaces/cicd-squabbler
⚠️ Bug: state-validation reject list now rejects the project's own name

📄 .machine_readable/bot_directives/methodology.a2ml:104

In .machine_readable/bot_directives/methodology.a2ml the reject-if-contains list previously held the placeholder token {{PROJECT}} so validation could detect an un-substituted, corrupt/template state file. The top-up pass replaced that token with the filled value CICD_SQUABBLER, inverting the rule's intent: legitimate state files that reference the project's own FFI namespace CICD_SQUABBLER (used in src/interface/ffi/src/main.zig, tests, and docs) will now be flagged as corrupt/template/stale and rejected. This token should have been excluded from substitution. Restore the placeholder marker so the guard again detects unfilled state, e.g. keep {{PROJECT}} (or use a distinct sentinel) rather than the resolved project name.

Keep the placeholder token in the reject list; it is a corruption sentinel, not a value to substitute.
reject-if-contains = ["{{PLACEHOLDER}}", "{{PROJECT}}", "rsr-template-repo"]
🤖 Prompt for agents
Code Review: Automated estate top-up fills derivable placeholders and removes boilerplate architecture files, but the descriptive project name breaks URL slots and causes state validation to reject the repository's own name.

1. ⚠️ Bug: PROJECT_NAME long name substituted into URLs/tags/paths, breaking them
   Files: docs/attribution/CITATIONS.adoc:10, docs/attribution/CITATIONS.adoc:14, docs/attribution/CITATIONS.adoc:21, docs/attribution/CITATIONS.adoc:25, docs/attribution/CITATIONS.adoc:29, docs/attribution/CITATIONS.adoc:33, .devcontainer/Containerfile:6, .devcontainer/Containerfile:29

   The descriptive `{{PROJECT_NAME}}` value ("cicd-squabbler — an intelligent, detachable CI/CD fighter") was mechanically substituted into slots that require the repo slug, producing broken output. In docs/attribution/CITATIONS.adoc the BibTeX cite key becomes `@software{cicd-squabbler — an intelligent, detachable CI/CD fighter_2026` (spaces/em-dash are illegal in BibTeX keys) and every citation URL becomes `https://github.com/hyperpolymath/cicd-squabbler — an intelligent, detachable CI/CD fighter`, which is not a resolvable URL. In .devcontainer/Containerfile the `WORKDIR` becomes a path containing spaces and an em-dash, and the build-command comment yields an invalid image tag. These slots should use the repo slug `cicd-squabbler` (i.e. the template should have used `{{REPO}}`/a slug token, not `{{PROJECT_NAME}}`). Fix by replacing the descriptive string with `cicd-squabbler` in the URL/key/WORKDIR/tag positions.

   Fix (Use the repo slug in the URL and a space-free BibTeX cite key (apply the same slug to the Harvard/OSCOLA/MLA/APA URLs).):
   @software{cicd_squabbler_2026,
     author = {Jewell, Jonathan},
     title = {cicd-squabbler — an intelligent, detachable CI/CD fighter},
     year = {2026},
     url = {https://github.com/hyperpolymath/cicd-squabbler},
     license = {MPL-2.0}
   }

   Fix (Use the repo slug for the image tag and WORKDIR so the path has no spaces and matches devcontainer.json.):
   # Build: podman build -t cicd-squabbler-dev -f .devcontainer/Containerfile .
   ...
   WORKDIR /workspaces/cicd-squabbler

2. ⚠️ Bug: state-validation reject list now rejects the project's own name
   Files: .machine_readable/bot_directives/methodology.a2ml:104

   In .machine_readable/bot_directives/methodology.a2ml the `reject-if-contains` list previously held the placeholder token `{{PROJECT}}` so validation could detect an un-substituted, corrupt/template state file. The top-up pass replaced that token with the filled value `CICD_SQUABBLER`, inverting the rule's intent: legitimate state files that reference the project's own FFI namespace `CICD_SQUABBLER` (used in src/interface/ffi/src/main.zig, tests, and docs) will now be flagged as corrupt/template/stale and rejected. This token should have been excluded from substitution. Restore the placeholder marker so the guard again detects unfilled state, e.g. keep `{{PROJECT}}` (or use a distinct sentinel) rather than the resolved project name.

   Fix (Keep the placeholder token in the reject list; it is a corruption sentinel, not a value to substitute.):
   reject-if-contains = ["{{PLACEHOLDER}}", "{{PROJECT}}", "rsr-template-repo"]

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Important

Your trial ends in 5 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

Was this helpful? React with 👍 / 👎 | Gitar

hyperpolymath and others added 2 commits August 5, 2026 14:15
…t a value

The estate top-up sweep substituted {{PROJECT}} here along with every other
token. This line is a DETECTOR list: the comment above it says these rules
detect corrupt/template/stale state files, so the tokens named in it are the
ones whose PRESENCE means a state file is broken.

Substituting it did two things. It blinded the {{PROJECT}} leak detector, and it
made the detector reject any state file containing this repo's own uppercased
name — the opposite of what the rule is for.

Same failure class as a template recipe rewriting the incident record that
documents its own bug: substituting tokens inside a thing that is ABOUT tokens.
Nothing else in this PR changes.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The previous commit on this branch was written by a script that read the file
through a shell command substitution. $(...) strips trailing newlines and
printf '%s' does not put one back, so the file lost its final newline and the
diff showed "\ No newline at end of file".

Content is otherwise byte-identical to that commit.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@sonarqubecloud

sonarqubecloud Bot commented Aug 5, 2026

Copy link
Copy Markdown

@hyperpolymath

Copy link
Copy Markdown
Owner Author

Closing in favour of a reworked substituter — hyperpolymath/standards#590.

This sweep filled {{TOKEN}} placeholders by plain text replacement across every file. Across the 90 repositories reviewed it drew 141 findings, and one is severe:

sed "s/{{PROJECT_NAME}}/$name/g"  →  sed "s/Conative Gating/$name/g"
sed -e "s/{{DATE}}/$DATE/g"       →  sed -e "s/2026-08-05/$DATE/g"

Those are the scripts whose job is to perform template substitution. Filling the left-hand side of their own sed expressions means template application silently stops working — and the breakage stays invisible until someone mints a repository from the template and gets a half-substituted tree.

Four further shapes came out of the same cause:

  • release.sh no longer substitutes {{DATE}} into release notes
  • just's own {{ARGS}} reported as an unfilled token, leaving repos permanently "not initialised"
  • instructional docs rewritten to "Replace laminar, laminar, {{DEPS}} with actuals"
  • documentation describing placeholders had its examples filled in

The rule plain replacement cannot express: a placeholder is sometimes a value to fill and sometimes the subject being discussed. standards#590 encodes that distinction and is tested against this exact corruption (9/9, the first three cases reproducing it).

Nothing here is lost — the placeholder filling will be redone with that tool. Closing rather than fixing forward because repairing 289 branches individually would repeat the mistake at the same scale.

@hyperpolymath
hyperpolymath deleted the chore/estate-topup branch August 18, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant