Skip to content

fix(ci): unbreak workflow YAML and add a complete actions.lock - #133

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/workflow-dependency-locking
Aug 27, 2026
Merged

fix(ci): unbreak workflow YAML and add a complete actions.lock#133
hyperpolymath merged 1 commit into
mainfrom
fix/workflow-dependency-locking

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Remediates GitHub Workflow Dependency Locking (public preview, no changelog entry), which rejects runs at startup_failure — zero jobs, no logs, nothing in REST or GraphQL. Full analysis: hyperpolymath/standards#657.

Proven on hyperpolymath/anamnesis: 6 of 6 workflows dead → 0 startup_failure, 13 running.

Five steps, in order — each blocks the next

1. Unbreak the workflow YAML. Any permissions: carrying a scalar with an indented mapping under it:

permissions: read-all
  actions: read        # <- mapping under a scalar. Unparseable.

This reaches past the one file: gh actions-lock refuses to run when any workflow in the repo fails to parse, so the repo can never acquire a lockfile and can never self-heal.

2. Repin standards reusables off commits with no actions.lock. The rejection requires the callee to be covered at the pinned SHA — unsatisfiable at a pre-lockfile commit.

3. Generate the lockfile with gh actions-lock.

4. Hand-add the reusable-caller entries the tool omits, as '<path>': [].

⚠️ Measured across 218 repos: P(startup_failure | has lockfile) = 91.7% vs 15.8% without — because every workflow a lockfile omits is rejected. A partial lock is worse than none. Running gh actions-lock and stopping there is how this outage spread.

5. Restore SPDX-License-Identifier to line 1, which the tool displaces with its own banner and which the workflow-security linter greps via head -1.

Verified before this PR was opened

0 unparseable workflows · lockfile covers every workflow, no omissions · SPDX on line 1 in every file. The script refuses to push if any of the three fails.

🤖 Generated with Claude Code

Remediates GitHub Workflow Dependency Locking (public preview), which
rejects runs at startup_failure with zero jobs and no logs. See
hyperpolymath/standards#657.

Five steps, in order, because each blocks the next:

1. Unbroke any workflow whose `permissions:` carried a scalar with an
   indented mapping under it - blind-permissions-insertion damage. This
   matters beyond the one file: gh actions-lock refuses to run when ANY
   workflow in the repo fails to parse, so the repo could never acquire a
   lockfile and could never self-heal.

2. Repinned hyperpolymath/standards reusables off commits that have no
   actions.lock. The rejection requires the CALLEE to be covered at the
   pinned SHA, which is unsatisfiable at a pre-lockfile commit.

3. Generated the lockfile with gh actions-lock.

4. Hand-added the reusable-workflow caller entries the tool omits, as
   '<path>': []. Measured across 218 repos: P(startup_failure | has
   lockfile) = 91.7% vs 15.8% without, because every workflow a lockfile
   OMITS is rejected. A PARTIAL lock is worse than none - running
   gh actions-lock and stopping there is how this outage spread.

5. Restored SPDX-License-Identifier to line 1, which the tool displaces
   with its own banner and which the workflow-security linter greps with
   head -1.

Verified before push: 0 unparseable workflows, lockfile covers every
workflow with no omissions, SPDX on line 1 in every file.

Proven on hyperpolymath/anamnesis: 6 of 6 workflows dead -> 0
startup_failure, 13 running.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@hyperpolymath
hyperpolymath merged commit 1f0722e into main Aug 27, 2026
21 of 27 checks passed
@hyperpolymath
hyperpolymath deleted the fix/workflow-dependency-locking branch August 27, 2026 05:55
@gitar-bot

gitar-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

Important

You are using the Gitar free plan. Upgrade to unlock code review, CI analysis, auto-apply, custom automations, and more.

Gitar

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 1d0b94fa-0bda-456f-a3e0-aaafb990e8d8

📥 Commits

Reviewing files that changed from the base of the PR and between fa74604 and 7395c3d.

⛔ Files ignored due to path filters (1)
  • .github/workflows/actions.lock is excluded by !**/*.lock
📒 Files selected for processing (36)
  • .github/workflows/boj-build.yml
  • .github/workflows/cargo-audit.yml
  • .github/workflows/casket-pages.yml
  • .github/workflows/cflite_batch.yml
  • .github/workflows/cflite_pr.yml
  • .github/workflows/codeql.yml
  • .github/workflows/dependabot-automerge.yml
  • .github/workflows/dogfood-gate.yml
  • .github/workflows/generator-generic-ossf-slsa3-publish.yml
  • .github/workflows/ghcr-publish.yml
  • .github/workflows/governance.yml
  • .github/workflows/hypatia-scan.yml
  • .github/workflows/instant-sync.yml
  • .github/workflows/mirror.yml
  • .github/workflows/pages.yml
  • .github/workflows/publish-aur.yml
  • .github/workflows/publish-chocolatey.yml
  • .github/workflows/publish-container.yml
  • .github/workflows/publish-copr.yml
  • .github/workflows/publish-debian-ppa.yml
  • .github/workflows/publish-flatpak.yml
  • .github/workflows/publish-homebrew.yml
  • .github/workflows/publish-macports.yml
  • .github/workflows/publish-nixpkgs.yml
  • .github/workflows/publish-obs.yml
  • .github/workflows/publish-packages.yml
  • .github/workflows/publish-scoop.yml
  • .github/workflows/publish-winget.yml
  • .github/workflows/push-email-notify.yml
  • .github/workflows/release.yml
  • .github/workflows/rust-ci.yml
  • .github/workflows/scorecard.yml
  • .github/workflows/secret-scanner.yml
  • .github/workflows/stress-test.yml
  • .github/workflows/workflow-linter.yml
  • .github/workflows/zig-ffi.yml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated action references across build, testing, security scanning, publishing and deployment workflows to current version tags.
    • Refreshed shared workflow revisions and granted required read access for workflow actions.
    • Standardised workflow management annotations and removed duplicate comments.
    • No application functionality, release behaviour or public interfaces changed.

Walkthrough

The pull request updates GitHub Actions references across workflow files. It replaces many commit-SHA references with version tags, updates reusable workflow pins and permissions, and adds or removes gh actions-lock comments.

Changes

Workflow updates

Layer / File(s) Summary
CI and validation action references
.github/workflows/boj-build.yml, .github/workflows/cargo-audit.yml, .github/workflows/casket-pages.yml, .github/workflows/cflite_*.yml, .github/workflows/codeql.yml, .github/workflows/dogfood-gate.yml, .github/workflows/generator-generic-ossf-slsa3-publish.yml, .github/workflows/ghcr-publish.yml, .github/workflows/release.yml, .github/workflows/rust-ci.yml, .github/workflows/stress-test.yml, .github/workflows/workflow-linter.yml, .github/workflows/zig-ffi.yml
Selected CI, validation, analysis, and release action references now use version tags instead of commit SHAs.
Publishing and distribution action references
.github/workflows/instant-sync.yml, .github/workflows/pages.yml, .github/workflows/publish-*.yml, .github/workflows/push-email-notify.yml
Publishing, deployment, notification, and package-dispatch action references now use version tags.
Reusable workflow permissions and pins
.github/workflows/governance.yml, .github/workflows/hypatia-scan.yml, .github/workflows/mirror.yml, .github/workflows/rust-ci.yml, .github/workflows/scorecard.yml, .github/workflows/secret-scanner.yml
The workflows add actions: read where specified and update reusable workflow commit pins. Management comments are also added or removed.
Workflow management comments
.github/workflows/*.yml
Several files add, remove, or retain the gh actions-lock management comment. Job logic and step inputs remain unchanged in the described action-reference updates.

Estimated code review effort: 2 (Simple) | ~15 minutes

Poem

A rabbit checks each workflow line
Tags now mark the actions fine
SHA pins hop out of view
Read permissions join the queue
Comments settle, neat and bright
CI bounds through the moonlit night


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 22 high

Alerts:
⚠ 22 issues (≤ 0 issues of at least minor severity)

Results:
22 new issues

Category Results
Security 22 high

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant