Skip to content

fix(ci): unbreak workflow YAML and add a complete actions.lock - #65

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/workflow-dependency-locking
Aug 27, 2026
Merged

fix(ci): unbreak workflow YAML and add a complete actions.lock#65
hyperpolymath merged 1 commit into
mainfrom
fix/workflow-dependency-locking

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Remediates GitHub Workflow Dependency Locking (public preview, no changelog entry), which rejects runs at startup_failure — zero jobs, no logs, nothing in REST or GraphQL. Full analysis: hyperpolymath/standards#657.

Proven on hyperpolymath/anamnesis: 6 of 6 workflows dead → 0 startup_failure, 13 running.

Five steps, in order — each blocks the next

1. Unbreak the workflow YAML. Any permissions: carrying a scalar with an indented mapping under it:

permissions: read-all
  actions: read        # <- mapping under a scalar. Unparseable.

This reaches past the one file: gh actions-lock refuses to run when any workflow in the repo fails to parse, so the repo can never acquire a lockfile and can never self-heal.

2. Repin standards reusables off commits with no actions.lock. The rejection requires the callee to be covered at the pinned SHA — unsatisfiable at a pre-lockfile commit.

3. Generate the lockfile with gh actions-lock.

4. Hand-add the reusable-caller entries the tool omits, as '<path>': [].

⚠️ Measured across 218 repos: P(startup_failure | has lockfile) = 91.7% vs 15.8% without — because every workflow a lockfile omits is rejected. A partial lock is worse than none. Running gh actions-lock and stopping there is how this outage spread.

5. Restore SPDX-License-Identifier to line 1, which the tool displaces with its own banner and which the workflow-security linter greps via head -1.

Verified before this PR was opened

0 unparseable workflows · lockfile covers every workflow, no omissions · SPDX on line 1 in every file. The script refuses to push if any of the three fails.

🤖 Generated with Claude Code

Remediates GitHub Workflow Dependency Locking (public preview), which
rejects runs at startup_failure with zero jobs and no logs. See
hyperpolymath/standards#657.

Five steps, in order, because each blocks the next:

1. Unbroke any workflow whose `permissions:` carried a scalar with an
   indented mapping under it - blind-permissions-insertion damage. This
   matters beyond the one file: gh actions-lock refuses to run when ANY
   workflow in the repo fails to parse, so the repo could never acquire a
   lockfile and could never self-heal.

2. Repinned hyperpolymath/standards reusables off commits that have no
   actions.lock. The rejection requires the CALLEE to be covered at the
   pinned SHA, which is unsatisfiable at a pre-lockfile commit.

3. Generated the lockfile with gh actions-lock.

4. Hand-added the reusable-workflow caller entries the tool omits, as
   '<path>': []. Measured across 218 repos: P(startup_failure | has
   lockfile) = 91.7% vs 15.8% without, because every workflow a lockfile
   OMITS is rejected. A PARTIAL lock is worse than none - running
   gh actions-lock and stopping there is how this outage spread.

5. Restored SPDX-License-Identifier to line 1, which the tool displaces
   with its own banner and which the workflow-security linter greps with
   head -1.

Verified before push: 0 unparseable workflows, lockfile covers every
workflow with no omissions, SPDX on line 1 in every file.

Proven on hyperpolymath/anamnesis: 6 of 6 workflows dead -> 0
startup_failure, 13 running.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@hyperpolymath
hyperpolymath merged commit 02561f9 into main Aug 27, 2026
5 of 6 checks passed
@hyperpolymath
hyperpolymath deleted the fix/workflow-dependency-locking branch August 27, 2026 04:52
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 26359954-083c-48be-ad95-a399f0a60dab

📥 Commits

Reviewing files that changed from the base of the PR and between 4149111 and 846122c.

⛔ Files ignored due to path filters (1)
  • .github/workflows/actions.lock is excluded by !**/*.lock
📒 Files selected for processing (11)
  • .github/workflows/codeql.yml
  • .github/workflows/governance.yml
  • .github/workflows/hypatia-scan.yml
  • .github/workflows/instant-sync.yml
  • .github/workflows/jekyll-gh-pages.yml
  • .github/workflows/jekyll.yml
  • .github/workflows/mirror.yml
  • .github/workflows/pages.yml
  • .github/workflows/push-email-notify.yml
  • .github/workflows/scorecard.yml
  • .github/workflows/secret-scanner.yml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated automated workflows to use current action and reusable workflow versions.
    • Improved consistency and maintainability across build, deployment, synchronisation, notification, and governance processes.
  • Security
    • Refreshed security scanning and secret detection workflows.
    • Added the required read permission for security analysis.
  • Reliability
    • Updated GitHub Pages publishing and other automation workflows to support ongoing, dependable operation.

Walkthrough

The pull request updates GitHub workflow action references, adds gh actions-lock management comments, refreshes reusable workflow commits, and grants actions: read permission to the secret scanner workflow.

Changes

Workflow reference updates

Layer / File(s) Summary
Version-tagged actions
.github/workflows/codeql.yml, .github/workflows/instant-sync.yml, .github/workflows/jekyll*.yml, .github/workflows/pages.yml, .github/workflows/push-email-notify.yml
Action references now use version tags. The workflows include gh actions-lock management comments.
Reusable workflow references
.github/workflows/governance.yml, .github/workflows/hypatia-scan.yml, .github/workflows/mirror.yml, .github/workflows/scorecard.yml, .github/workflows/secret-scanner.yml
Reusable workflow references now use updated commit SHAs. The secret scanner also adds actions: read permission.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

A rabbit checks each workflow line
Tags replace the hashes in neat design
Reusable scans hop to a newer place
Read permissions join the chase
gh actions-lock marks the trail
Clean YAML makes the rabbit’s tale

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gitar-bot

gitar-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

Important

You are using the Gitar free plan. Upgrade to unlock code review, CI analysis, auto-apply, custom automations, and more.

Gitar

@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 3 high

Alerts:
⚠ 3 issues (≤ 0 issues of at least minor severity)

Results:
3 new issues

Category Results
Security 3 high

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The pull request is currently not up to standards. The most critical issue is that the .github/workflows/actions.lock file, a primary deliverable of this PR, is missing from the submitted changes. Without this file, the dependency locking mechanism is incomplete.

Furthermore, the PR introduces security regressions by reverting several third-party actions from immutable commit SHA pins to mutable version tags. This introduces a supply chain risk where upstream tags could be maliciously modified. Finally, there is a remaining implementation gap regarding the workflow permissions syntax fix; the visible changes add specific permissions but do not clearly resolve the scalar-vs-mapping conflict mentioned in the acceptance criteria.

About this PR

  • The file .github/workflows/actions.lock is missing from the PR. This is a primary requirement for unbreaking the workflow dependency locking.

Test suggestions

  • Verify all workflow YAML files parse correctly (no scalar/mapping conflicts in permissions)
  • Verify SPDX-License-Identifier header is positioned on line 1 in all modified workflows
  • Verify all external actions and reusable workflows use pinned versions or SHAs
  • Verify the actions.lock file covers all workflows including manually added reusable-caller entries
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify all external actions and reusable workflows use pinned versions or SHAs
2. Verify the actions.lock file covers all workflows including manually added reusable-caller entries
Low confidence findings
  • The requirement to fix the invalid YAML syntax (scalar 'permissions: read-all' followed by an indented mapping) appears unaddressed. The current diff shows additions to the mapping but does not show the removal of the conflicting scalar value.

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

steps:
- name: Send push notification email
uses: dawidd6/action-send-mail@12335b969ae3fb71bee5f2c6b829744261aec34c # pinned
uses: dawidd6/action-send-mail@v3.12.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 HIGH RISK

Pin this action to a specific commit SHA to ensure the workflow remains secure. Relying on mutable tags for third-party actions is a security risk.

See Issue in Codacy

steps:
- name: Trigger Propagation
uses: peter-evans/repository-dispatch@28959ce8df70de7be546dd1250a005dd32156697 # v4.0.1
uses: peter-evans/repository-dispatch@v4.0.1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 HIGH RISK

Pin all third-party GitHub Actions to a full-length commit SHA. Using tags instead of SHAs makes the workflow susceptible to unauthorized changes in the upstream repository.

See Issue in Codacy

- name: Setup Ruby
# https://github.com/ruby/setup-ruby/releases/tag/v1.207.0
uses: ruby/setup-ruby@95ef2b042f9d7a56d8268cba8559e2842e2ad01b
uses: ruby/setup-ruby@v1.321.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 HIGH RISK

This change unpins a third-party GitHub Action from a commit SHA. Security best practices require using the full-length commit SHA to ensure the action is immutable and to protect against supply chain attacks.

See Issue in Codacy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant