policy: Bun is tier 1, Deno is being removed — correct local CLAUDE.md - #72
Conversation
|
Warning Review limit reachedNext included review available in 5 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (1)
🧰 Additional context used🪛 LanguageTool.claude/CLAUDE.md[misspelling] ~10-~10: Use “a” instead of ‘an’ if the following word doesn’t start with a vowel sound, e.g. ‘a sentence’, ‘a university’. (EN_A_VS_AN) [misspelling] ~10-~10: This word is normally spelled as one. (EN_COMPOUNDS_ANTI_PATTERNS) 🔇 Additional comments (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe tooling policy now uses Bun instead of Deno for JavaScript and TypeScript execution, AffineScript targets, JavaScript glue, dependency enforcement, production installs, and one-off tooling. ChangesBun tooling policy
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This localized policy-only change updates the documented JavaScript runtime and dependency-management guidance without modifying code, workflows, or build files; no actionable merge-blocking risk remains beyond normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
The PR successfully establishes Bun as the Tier 1 runtime and updates enforcement rules for dependency management. However, there is a significant discrepancy between the PR description and the actual changes. The description claims to restore 'ReScript' references to Rule 1 and the Banned table to fix 'blanking scars,' yet these modifications are missing from the code diff.
Additionally, while Deno has been removed from the list of allowed tools, it has not been added to the Banned table. This omission leaves the policy incomplete, as the Banned table should explicitly redirect contributors from deprecated tools like Deno to the new standard, Bun.
About this PR
- The PR description mentions repairing 'blanking scars' by restoring 'ReScript' in Rule 1 and adding a row for it in the BANNED table. These changes are absent from the current diff, where Rule 1 still references 'TypeScript' and the BANNED table lacks the ReScript entry.
Test suggestions
- Bun is listed in the ALLOWED table as Tier 1
- BANNED table redirects Node.js, npm, and pnpm/yarn to Bun
- Enforcement Rule 2 mandates package.json and bun.lock
- Enforcement Rule 3 mandates production installs via 'bun install --production'
- Rule 1 is updated to reference ReScript as per the PR description
- A BANNED row for ReScript is restored as per the PR description
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Rule 1 is updated to reference ReScript as per the PR description
2. A BANNED row for ReScript is restored as per the PR description
Low confidence findings
- The PR description's 'was' state for several lines (specifically regarding Rule 1 and JavaScript notes) contradicts the actual content of the file prior to this change. This suggests the file state might be different than assumed in the PR summary.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| | pnpm/yarn | Deno | | ||
| | Node.js | Bun | | ||
| | npm | Bun | | ||
| | pnpm/yarn | Bun | |
There was a problem hiding this comment.
🟡 MEDIUM RISK
Suggestion: Add Deno to the Banned table to complete the policy transition.
| | pnpm/yarn | Bun | | |
| pnpm/yarn | Bun | | |
| Deno | Bun | |
Owner ruling 2026-08-26: "deno is to go and bun is the way we are going, put it
first everywhere unless not possible and explain why if not".
This file is what an agent reads FIRST and it listed Bun as BANNED with Deno as
its replacement. Correcting hyperpolymath/standards (#655) fixes one copy of
~372 - agents read the local one. This is that local copy.
ALLOWED **Deno** "Replaces Node/npm/bun" -> **Bun** tier 1
BANNED | Bun | Deno | -> row REMOVED
BANNED Node.js / npm / pnpm/yarn -> Deno -> -> Bun
rule "No package.json for runtime deps - use deno.json imports"
-> Use package.json + bun.lock; a manifest is REQUIRED
rule "No node_modules in production"
-> bun install --production, pinned via bun.lock
pkg JS deps: Deno -> JS deps: Bun (package.json + bun.lock), bunx
WHY THE MANIFEST RULE MATTERS MOST. "No package.json for runtime deps" did not
express a preference - it told repos not to declare their dependencies at all.
hyperpolymath/ubicity imported zod and glob, shipped NO manifest of any kind,
and could not build under ANY toolchain. Fixed in ubicity#107; the rule that
caused it is fixed here.
ALSO REPAIRED - blanking scars from the ReScript purge, which substituted the
token with an EMPTY STRING rather than removing the text:
| | AffineScript | -> | ReScript | AffineScript |
1. **No new files** ... -> **No new ReScript files** ...
| **JavaScript** | Only where cannot | -> Only where AffineScript cannot
Restoring the NAME in a policy table does not reintroduce the language. Same
root cause as the rm -rf /lib found in wordpress-tools#62.
Policy text only - no code, no workflows, no build files. 1 file(s).
NOT FOLDED IN: "Fallback: Nix (flake.nix)" is stale (Guix superseded Nix per
ADR-2026-STACK-MIGRATION) but that is a separate ruling; flagged, not changed.
7618af4 to
9e455b9
Compare
Review feedback from codacy-production and coderabbitai on the policy wave. Three substantive points, all accepted: 1. ".ts CONTRADICTION" (codacy, MEDIUM, raised on most of the wave). The Bun row said "Executes .ts directly, no build step" in a file whose BANNED table bans TypeScript. OWNER RULING: TypeScript "should not exist at all", so advertising Bun's TypeScript capability is wrong regardless of whether it is true. Every .ts reference is removed from the row, including "JS/TS" in its label. 2. "DENO MISSING FROM BANNED" (codacy, raised repeatedly). The wave removed Deno from ALLOWED but never added it to BANNED, so the ruling was only half expressed. Added | Deno | Bun |. 3. "UNPINNED bunx" (coderabbitai, Security & Privacy). A bare `bunx <tool>` can fetch a package outside package.json/bun.lock, and can start Node via a shebang - both contrary to estate SHA-pinning doctrine and the Node ban. Guidance now requires a declared devDependency plus `bunx --no-install --bun <tool>`. NOT taken: "a npm-compatible" (LanguageTool is wrong, "an" is correct before a vowel sound); "--frozen-lockfile is redundant" (correct - no change needed, and none made); the Nix->Guix point (real, but a separate ruling, deliberately not folded into a Deno/Bun change).
1 participant
Owner ruling, 2026-08-26:
This repo's
.claude/CLAUDE.mdis what an agent reads first. Correctinghyperpolymath/standards(#655) fixes one copy of ~372 — agents read the local one.What this PR actually changes
Every line below was verified present in this PR's own diff — nothing is claimed that isn't here.
| Bun | Deno |row removedpackage.json+bun.lock)bun install --productionreplaces the node_modules rulebunx --no-install --bunOnly where cannot→ Only where AffineScript cannot| **** |→ AffineScriptReview feedback addressed
.tsdirectly" inside a file that bans TypeScript. Owner ruling: TypeScript should not exist at all — so every.tsreference is gone from the row, including JS/TS in its label. It now reads JS runtime, running compiled ESM/JS.bunx(coderabbitai, Security & Privacy): a barebunx <tool>can fetch a package outsidebun.lockand can start Node via a shebang. Guidance now requires a declared devDependency plusbunx --no-install --bun.Not taken: "a npm-compatible" (LanguageTool is wrong — "an" is correct before a vowel sound); "
--frozen-lockfileis redundant" (correct, and no such flag was added); the Nix → Guix point (real, but a separate ruling — deliberately not folded into a Deno/Bun change).Scope
Policy text only — no code, no workflows, no build files.
Related: #655 (governing document), #658 (Deno→Bun assessment: 18 repos blocked on
@affinescript/*npm packages that do not exist), #659 (policy duplicated into ~372 copies).