Skip to content

fix(shell): declare the shell — shebang where executed, directive where sourced #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperpolymath merged 2 commits into from
Aug 27, 2026
Merged

fix(shell): declare the shell — shebang where executed, directive where sourced #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a98a1bf
fix(shell): declare the shell — shebang where executed, directive whe…
hyperpolymath Aug 26, 2026
53e84ef
Merge branch 'main' into fix/shellcheck-shebang-and-shell-directive
hyperpolymath Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions nick-shells/shell/baseline.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# shellcheck shell=bash

@codacy-production codacy-production Bot Aug 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ LOW RISK

Nitpick: The documentation on line 7 describes the script as POSIX-compatible, but the addition of the bash directive and the use of ${BASH_SOURCE[0]} on line 19 make it Bash-specific. Consider updating the description to clarify that this is a Bash configuration to avoid confusion for users of shells like dash or ash.

# SPDX-License-Identifier: MPL-2.0 OR MPL-2.0
# SPDX-FileCopyrightText: 2025 Jonathan D.A. Jewell <hyperpolymath>
#
Expand Down
1 change: 1 addition & 0 deletions nick-shells/shell/examples/developer.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# shellcheck shell=bash
# SPDX-License-Identifier: MPL-2.0 OR MPL-2.0
# SPDX-FileCopyrightText: 2025 Jonathan D.A. Jewell <hyperpolymath>
#
Expand Down
1 change: 1 addition & 0 deletions nick-shells/shell/examples/interactive.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# shellcheck shell=bash
# SPDX-License-Identifier: MPL-2.0 OR MPL-2.0
# SPDX-FileCopyrightText: 2025 Jonathan D.A. Jewell <hyperpolymath>
#
Expand Down
1 change: 1 addition & 0 deletions nick-shells/shell/examples/minimal.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# shellcheck shell=bash
# SPDX-License-Identifier: MPL-2.0 OR MPL-2.0
# SPDX-FileCopyrightText: 2025 Jonathan D.A. Jewell <hyperpolymath>
#
Expand Down
1 change: 1 addition & 0 deletions nick-shells/shell/modules/aliases.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# shellcheck shell=bash
# SPDX-License-Identifier: MPL-2.0 OR MPL-2.0
# SPDX-FileCopyrightText: 2025 Jonathan D.A. Jewell <hyperpolymath>
#
Expand Down
1 change: 1 addition & 0 deletions nick-shells/shell/modules/behavior.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# shellcheck shell=bash
# SPDX-License-Identifier: MPL-2.0 OR MPL-2.0
# SPDX-FileCopyrightText: 2025 Jonathan D.A. Jewell <hyperpolymath>
#
Expand Down
1 change: 1 addition & 0 deletions nick-shells/shell/modules/dev.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# shellcheck shell=bash
# SPDX-License-Identifier: MPL-2.0 OR MPL-2.0
# SPDX-FileCopyrightText: 2025 Jonathan D.A. Jewell <hyperpolymath>
#
Expand Down
1 change: 1 addition & 0 deletions nick-shells/shell/modules/editor.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# shellcheck shell=bash
# SPDX-License-Identifier: MPL-2.0 OR MPL-2.0
# SPDX-FileCopyrightText: 2025 Jonathan D.A. Jewell <hyperpolymath>
#
Expand Down
1 change: 1 addition & 0 deletions nick-shells/shell/modules/history.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# shellcheck shell=bash
# SPDX-License-Identifier: MPL-2.0 OR MPL-2.0
# SPDX-FileCopyrightText: 2025 Jonathan D.A. Jewell <hyperpolymath>
#
Expand Down
1 change: 1 addition & 0 deletions nick-shells/shell/modules/locale.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# shellcheck shell=bash
# SPDX-License-Identifier: MPL-2.0 OR MPL-2.0
# SPDX-FileCopyrightText: 2025 Jonathan D.A. Jewell <hyperpolymath>
#
Expand Down
1 change: 1 addition & 0 deletions nick-shells/shell/modules/path.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# shellcheck shell=bash
# SPDX-License-Identifier: MPL-2.0 OR MPL-2.0
# SPDX-FileCopyrightText: 2025 Jonathan D.A. Jewell <hyperpolymath>
#
Expand Down
1 change: 1 addition & 0 deletions nick-shells/shell/modules/security.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# shellcheck shell=bash
# SPDX-License-Identifier: MPL-2.0 OR MPL-2.0
# SPDX-FileCopyrightText: 2025 Jonathan D.A. Jewell <hyperpolymath>
#
Expand Down
1 change: 1 addition & 0 deletions nick-shells/shell/modules/xdg.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# shellcheck shell=bash
# SPDX-License-Identifier: MPL-2.0 OR MPL-2.0
# SPDX-FileCopyrightText: 2025 Jonathan D.A. Jewell <hyperpolymath>
#
Expand Down
Loading