Repository navigation
fix(config): warn on memory config and feed gate on direct transport - #153
Merged
Merged
Conversation
scalo reads a `memory` section for the guard's limit and thresholds. SCALO_CASCADE_SECTIONS did not list it. Only the wrapper reads config.yaml in the working directory. A `memory:` block there was dropped with no warning.
SCALO_CASCADE_SECTIONS now lists `memory`. The single-underscore env check leaves scalo's DFE_TRANSFORM_VRL_MEMORY_LIMIT_BYTES, _PRESSURE_THRESHOLD and _CGROUP_HEADROOM names alone.
Only the bus ticker called set_memory on the scaling pressure. Nothing called it on the direct transport. The memory gauge task now feeds the gate on both transports once a second. The bus ticker no longer does.
config-schema.{json,yaml} are regenerated for the Config doc comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scalo reads a
memorysection for the guard's limit and thresholds. SCALO_CASCADE_SECTIONS did not list it. Only the wrapper reads config.yaml in the working directory. Amemory:block there was dropped with no warning.SCALO_CASCADE_SECTIONS now lists
memory. The single-underscore env check leaves scalo's DFE_TRANSFORM_VRL_MEMORY_LIMIT_BYTES, _PRESSURE_THRESHOLD and _CGROUP_HEADROOM names alone.Only the bus ticker called set_memory on the scaling pressure. Nothing called it on the direct transport. The memory gauge task now feeds the gate on both transports once a second. The bus ticker no longer does.
config-schema.{json,yaml} are regenerated for the Config doc comment.