Repository navigation
fix(config): mark memory restart-required and correct stale comments - #351
Merged
Merged
Conversation
The memory guard is built once at start. Reloads never applied `memory`, though the config said it was hot-reloaded. `memory` is now in the restart group. A reload that changes it logs a restart warning. Correct stale comments about: - where config-check runs - when .env is read - the scaling gate - RowBinary sending JSON columns as text - the pre-warm recheck Remove a duplicated reload list and benchmark figures from a deleted bench. The dev compose file stops mounting a deleted init.sql. config.dev.yaml connects to Kafka's host port. Remove two unlinked reference files that contradicted dfe-schemas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The memory guard is built once at start. Reloads never applied
memory, though the config said it was hot-reloaded.memoryis now in the restart group. A reload that changes it logs a restart warning.Correct stale comments about:
Remove a duplicated reload list and benchmark figures from a deleted bench.
The dev compose file stops mounting a deleted init.sql. config.dev.yaml connects to Kafka's host port.
Remove two unlinked reference files that contradicted dfe-schemas.