Repository navigation
fix(capture): drop the disable lists and no_capture tags - #347
Merged
Merged
Conversation
capture_mode and table_capture_modes are the only capture switches. Remove disable_json_tables and disable_raw_tables from the metadata config. A table comment's @no_capture_json and @no_capture_raw tags no longer change the capture mode. A table with no @capture_mode tag takes its table_capture_modes entry, else the global capture_mode. Remove the tests for the disable lists and no_capture tags. The tag-removal test also covers a table with its own table_capture_modes entry. The config schema is regenerated with dfe-loader config-schema --dir docs. The loader does not read capture_json. Its doc says so. capture_raw still gates _raw under full mode.
catinspace-au
added a commit
to hyperi-io/dfe-engine
that referenced
this pull request
Nov 14, 2026
The loader acknowledgement fixture comment named a branch commit. It now names 412f65d82d393b0fde0e0c92deca90d7ce3ff818, the merge of hyperi-io/dfe-loader#347, whose docs/config-schema.json matches the fixture byte for byte.
catinspace-au
added a commit
to hyperi-io/dfe-engine
that referenced
this pull request
Nov 14, 2026
* fix(capture): stop seeding the loader's disable lists hyperi-io/dfe-loader#347 drops disable_json_tables and disable_raw_tables from the loader, so both loader seeds stop writing them. The loader acknowledgement fixture is the loader branch's docs/config-schema.json, copied byte for byte. The comment names the matching commit. tests/fixtures/contract/dfe-loader still matches the pinned loader release. The fixture changes with the pin once a loader release has the change. * fix(capture): name the merged loader commit for its fixture The loader acknowledgement fixture comment named a branch commit. It now names 412f65d82d393b0fde0e0c92deca90d7ce3ff818, the merge of hyperi-io/dfe-loader#347, whose docs/config-schema.json matches the fixture byte for byte.
|
Released in v1.18.72 -- https://github.com/hyperi-io/dfe-loader/releases/tag/v1.18.72 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
capture_mode and table_capture_modes control the loader's capture mode. disable_json_tables and disable_raw_tables leave the metadata config. Without an @capture_mode tag, a table takes its table_capture_modes entry or falls back to the global capture_mode.
capture.rs drops the lists and their warning. It stops reading @no_capture_json and @no_capture_raw. These table tags do nothing.
hyperi-io/dfe-engine#1165 updates the engine's loader seeds and acknowledgement fixture for this change. Merge this PR first.
Two fixtures must wait for a loader release with this change. The engine's tests/fixtures/contract/dfe-loader must match the pinned release. dfe-infra's scripts/tests/fixtures/contracts/dfe-loader.json must match the published thin chart.