Repository navigation
fix(search): list JSON keys in the search filter panel again - #219
Merged
Merged
Conversation
The search filter panel showed "No filters available" for a native JSON column, because the key-values request threw ReferenceError: return_optionalChain is not defined. The minified app build turned the optional chain in isNumericOperand (common-utils/src/dfe/jsonPath.ts) into a call to a helper it never defined. That was the only such call in the shipped chunks. The guard now checks for a match without optional chaining, which gives the same result for every input.
Contributor
|
Released in v0.3.25 -- https://github.com/hyperi-io/dfe-hyperdx/releases/tag/v0.3.25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The search filter panel showed "No filters available" for a native JSON column because the key-values request threw ReferenceError: return_optionalChain is not defined. The minified app build turned the optional chain in isNumericOperand (common-utils/src/dfe/jsonPath.ts) into a call to a helper it never defined. That was the only such call in the shipped chunks.
The guard checks for a match without optional chaining. It gives the same result for every input.