Repository navigation
fix(system): report the stack whose manifest matches the running images - #1171
Open
catinspace-au wants to merge 3 commits into
Open
catinspace-au wants to merge 3 commits into
catinspace-au wants to merge 3 commits into
Conversation
A Docker install's compose keeps its build-time stack name. A later stack still shows that older name while running newer images. The engine reads published stack manifests (ghcr.io/hyperi-io/dfe-stack-manifest) in the background after startup. It reports the newest release, then the newest prerelease, whose digests match every image in DFE_ENGINE_STACK_IMAGES. This matches dfe-infra's ordering: a release beats release candidates with identical images. - /system/version and /system/deployment report the matching stack with source "registry". The deploy-repo pins still win. The stack_version label stays the fallback. - Startup and readiness never wait on the registry. A failure or no match logs one warning and keeps the label. - DFE_ENGINE_STACK_RESOLVE=false switches off registry lookup for an air-gapped site. DFE_ENGINE_STACK_MANIFEST_REPOSITORY points the lookup at a mirror. - The settings loader now keeps false or zero top-level environment values. Dropping them caused DFE_ENGINE_STACK_RESOLVE=false to be ignored. The resolver does not verify the artifact signature.
The stack resolution task caught only registry errors. Other exceptions ended it with no log. - Each failure except cancellation logs one warning with its reason. The stack_version label is kept. Cancellation passes through. - A non-list tag response is rejected as a registry error. - A deploy repo's stack pin takes precedence, so registry reads are skipped. The pin is read the same way as in deployment facts. - Tests cover startup with a stalled registry, task cancellation at shutdown, and skipping registry reads for pinned stacks.
ty flags a contextmanager annotated as Iterator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Docker install's compose keeps its build-time stack name. A later stack still shows that older name while running newer images.
The engine reads published stack manifests (ghcr.io/hyperi-io/dfe-stack-manifest) in the background after startup. It reports the newest release, then the newest prerelease, whose digests match every image in DFE_ENGINE_STACK_IMAGES. This matches dfe-infra's ordering: a release beats release candidates with identical images.
The resolver does not verify the artifact signature.