Repository navigation
fix(secrets): mint passwords and keys from letters and digits - #1168
Merged
Merged
Conversation
The ClickHouse service, org and group passwords and the SCIM provisioning password are 32 letters and digits. The CLI's throwaway JWT key is 64 letters and digits. They were minted with token_urlsafe, whose - and _ get rewritten by shells, .env files and URL-form DSNs. Only mint_value in dfe_engine/secrets.py mints them. Session epochs and bearer tokens stay as they are.
|
Released in v1.22.91 -- https://github.com/hyperi-io/dfe-engine/releases/tag/v1.22.91 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ClickHouse service, org and group passwords and the SCIM provisioning password are 32 letters and digits. The CLI's throwaway JWT key is 64 letters and digits. They were minted with token_urlsafe, whose - and _ get rewritten by shells, .env files and URL-form DSNs.
Only mint_value in dfe_engine/secrets.py mints them. Session epochs and bearer tokens stay as they are.