Skip to content

cleanup test-e2e additional flags so they're easier to add #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
brandon-pereira wants to merge 2 commits into
base: main
Choose a base branch
from
Open

cleanup test-e2e additional flags so they're easier to add #1543

brandon-pereira wants to merge 2 commits into from

Conversation

@brandon-pereira
Copy link
Member

@brandon-pereira brandon-pereira commented Dec 31, 2025 •
edited
Loading

Also fixes issue where --ui passed incorrectly

Feedback for Claude: we currently don't support any arguments with spaces at the makefile level, so no need for space parsing

@changeset-bot
Copy link

changeset-bot bot commented Dec 31, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 64fd6ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 31, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview, Comment Jan 2, 2026 5:44pm

@claude
Copy link

claude bot commented Dec 31, 2025 •
edited
Loading

✅ No critical issues found.

The refactoring improves code maintainability by centralizing flag building. Changes look good:

  • Eliminates duplicate conditional logic across both modes
  • Properly handles flag concatenation without spaces issue (as noted in PR description)
  • Maintains backward compatibility with existing behavior

@github-actions
Copy link
Contributor

github-actions bot commented Dec 31, 2025 •
edited
Loading

E2E Test Results

✅ All tests passed • 55 passed • 4 skipped • 710s

Status Count
✅ Passed 55
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 4

Tests ran across 4 shards in parallel.

View full report →

wrn14897
wrn14897 reviewed Jan 2, 2026
View reviewed changes
scripts/test-e2e.sh Outdated
Comment on lines 124 to 135
# Build additional flags
ADDITIONAL_FLAGS=""
if [ -n "$TAGS" ]; then
ADDITIONAL_FLAGS="--grep $TAGS"
fi
if [ "$UI_MODE" = true ]; then
ADDITIONAL_FLAGS="$ADDITIONAL_FLAGS --ui"
fi

# Main execution
if [ "$LOCAL_MODE" = true ]; then
run_local_mode
Copy link
Member

@wrn14897 wrn14897 Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: what do you think about moving all these flags before the function defs? imo its easier to follow

Copy link
Member Author

@brandon-pereira brandon-pereira Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wrn14897 good idea, updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teeohhem teeohhem Awaiting requested review from teeohhem

@wrn14897 wrn14897 Awaiting requested review from wrn14897

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brandon-pereira @wrn14897