Repository navigation
Recover pools stuck in a rolling restart; clear stale Degraded (v0.3.2) - #18
Merged
Merged
Conversation
A pool whose proxy was down when a rolling restart began never recovered: the restart retried excluding a pod from the proxies forever, it returned early on every pass, and the proxy Deployment was applied only after it, so the proxy fix in v0.3.1 never landed. - The proxy Deployment is applied before the rolling restart. - Exclude and include go to every proxy whose process runs, Ready or not, and skip the rest. Requiring Ready also deadlocked one-node pools: excluding the only backend makes the proxies un-Ready, so the include never went out. A proxy that is not running holds no exclusions (they are in memory). - Exclude treats 409 (already excluded) and the proxy's own not-in-pool 404 as done, so a retry after a partial failure succeeds. - A restart that has excluded nothing while no update is pending is cleared, as was done by hand on the pool. - Degraded is set False once a reconcile completes; it stayed True on healthy pools. Chart 0.3.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs found on
shared-pool-1after v0.3.1.1. A pool stuck in a rolling restart never recovered. The pool's proxy was down when a rolling restart began. The restart then retried excluding a pod from the proxies forever and returned early on every pass. Because the proxy Deployment was applied only after the restart step, v0.3.1's proxy fix never landed. It needed the restart state cleared by hand.
2. A stale
Degraded=Truestayed on healthy pools.setFailedStatusset it and nothing cleared it. It's now set toFalse(reasonReconciled) once a reconcile completes.Chart and README bumped to 0.3.2;
docs/compatibility.mdhas an upgrade note. No pod templates change.Tests:
admin, and moves past the exclusion;DegradedbecomesFalse.DegradedleftTrueeach fails a spec.go test ./...with envtest,go vet, andmake lint(0 issues) pass.