fix(ui): clarify actions on the connected computer - #301
Merged
Merged
Conversation
Resolve the UI directory before extension installation and publish the same path through DaemonState. Remote extensions can now inspect the exact static root used by the local router during install and startup. Co-Authored-By: Nova (GPT-6) <noreply@openai.com>
Discover the versioned host bridge at runtime and install streaming HTTP and WebSocket transports alongside native discovery. Remote URL resolution is confined to the selected daemon's /api/v1 namespace, including encoded path traversal checks, while the bridge carries abortable request streams. Co-Authored-By: Nova (GPT-6) <noreply@openai.com>
Retire request cancellation watchers at EOF and abort pending exchanges on drop. Split browser chunks to each consumer's requested capacity. Socket drops clear JavaScript callbacks before closing. Startup rejects incomplete or malformed bridge contracts before installing transports. Co-Authored-By: Nova (GPT-6) <noreply@openai.com>
Let extension crates detect the browser Remote bridge before app transport initialization, preventing accidental same-origin requests during bootstrap. Pin the current reviewed raw HTML sinks so new injection surfaces fail CI. Co-Authored-By: Nova (GPT-5.6 Sol) <noreply@openai.com>
Render shapes through typed SVG nodes. Load vendor marks as rebased CSS mask assets so tinting works without injected SVG markup. Reject every future inner_html attribute in the UI security gate. Co-Authored-By: Nova (GPT-5.6 Sol) <noreply@openai.com>
Vendor tachys 0.2.18 with a narrow hc-static policy for compiler-generated DOM templates. Validate owned icon SVG against an inert structural grammar before conversion and leave general raw HTML assignments browser-blocked. Create preview workers through the private policy. Only registered blob URLs from embedded static source can become TrustedScriptURL values. Co-Authored-By: Nova (GPT-5.6 Sol) <noreply@openai.com>
Reject escaped paint URLs and limit owned SVG conversion to the SVG renderer. An embedding host can provide the sole static DOM policy so verified service workers and compiler templates share one named policy. Restore all other vendored source bytes to the published tachys package. Keep upstream formatting intact so future patch audits stay narrow.
Malformed JavaScript response headers now return transport errors instead of throwing through WASM. Require arrays of exact string pairs before reading their values. Match forbidden sink identifiers regardless of comments around assignments, and propagate search failures so a broken gate cannot report success. Firefox bridge tests cover malformed headers and the valid streamed path. Co-Authored-By: Nova (GPT-6) <noreply@openai.com>
Name Hypercolor as the product and use this computer for host-local operations. Keep daemon terminology in APIs, config keys, protocol names, logs, and developer comments where it identifies the actual process. Co-Authored-By: Nova (GPT-5.6 Sol) <noreply@openai.com>
Bring the user-facing copy changes onto the merged transport foundation so the pull request contains only wording and matching assertions.
|
Warning Review limit reached
This review includes 14 billable files and costs up to $3.50. Or wait 24 seconds for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (14)
Comment |
Combine the user-facing copy with the merged application state isolation before validating the final engine revision consumed by the native app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The shared UI names Hypercolor in actions and errors, and uses "the connected computer" when instructions refer to the machine running the lighting engine. Remote users can now tell where to install OpenRGB or change capture settings without interpreting daemon terminology.
Why
The same UI runs locally and through Remote. Wording such as "this computer" can point at the browser's machine when the action belongs on the connected host.
Verification
just verifypasses locally (targeted UI checks used)just denypasses (no dependency or license changes)just ui-testandjust ui-buildpass (141 UI unit tests and the production WASM build)The UI unit suite passed after merging the shared Remote transport support. The implementation worker also passed UI Clippy and formatting checks. The diff changes user-facing strings and their matching assertions; configuration keys and protocol identifiers retain their existing names.