Skip to content

Ignore invalid transcript timestamps - #276

Open
happykawayigt wants to merge 1 commit into
hyperaudio:mainfrom
happykawayigt:fix/ignore-invalid-word-times
Open

Ignore invalid transcript timestamps#276
happykawayigt wants to merge 1 commit into
hyperaudio:mainfrom
happykawayigt:fix/ignore-invalid-word-times

Conversation

@happykawayigt

Copy link
Copy Markdown

Summary

  • ignore transcript nodes whose data-m value cannot be parsed, preventing them from poisoning playhead binary search
  • return before changing transcript state when clicks target whitespace or malformed timed nodes
  • keep malformed nodes in a clean, inert visual state
  • add regression tests for both invalid timestamp paths

Validation

  • npm run build
  • npm test -- --runInBand (76 tests passed)
  • git diff --check

Fixes #262

@happykawayigt
happykawayigt marked this pull request as ready for review July 30, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setPlayHead runs updateTranscriptVisualState with NaN before its own guard; a malformed data-m permanently poisons the binary search

1 participant