Repository navigation
Chore/release hygiene deploy - #14
Merged
Merged
Conversation
- Verify the schema revision on worker startup, as the API and CLI already do and as docs/operations/worker.md claimed. The worker now exits 1 instead of polling against a database it was not built for. - Hold every outbound attempt to an overall deadline of the connect and read timeouts combined. The client timeouts each bound a single wait, so a destination trickling bytes could keep a request open indefinitely, outliving the lease and stalling the batch and worker shutdown. - Stream the response and never read its body, so a destination cannot dictate how much memory an attempt uses. - End the read transaction opened by load_submissions before sending, so no transaction is held across outbound HTTP calls. - Record the rest of a batch when one completion fails to record, instead of abandoning every remaining result and forcing duplicate sends. - Warn at startup when FORMS_WORKER_LEASE_SECONDS does not outlast one attempt.
An idempotent replay reported delivery.queued from the endpoint's current webhook configuration. If the webhook was added or removed after the original request, the replay claimed a delivery that did not exist, or denied one that did. It now reports whether the stored submission owes a delivery.
CI now installs SQLAlchemy 2.1, where Select is generic over a variadic row type, so the existing bound Select[Any] no longer accepts a two-entity select and mypy fails in list_submissions. Bound the type variable by a small protocol for "has where()" instead, which type checks on both 2.0 and 2.1 (pyproject allows sqlalchemy>=2.0). No runtime change.
- docs/development/releasing.md: the release checklist (version bump, release notes, PG suite, mkdocs build, annotated tag on the merge commit) and a record of the v0.2.1 discrepancy: the tag points at 235f8af, where __version__ is still 0.2.0, and has no release notes. The tag is not moved; the next release resolves it. - Dockerfile: one non-root image for the API (default), the worker, migrations and the operator CLI. uvicorn runs with --no-proxy-headers so FORMS_TRUSTED_PROXY_HOPS stays the only trust knob for XFF. - compose.yaml: example stack of postgres, one-shot migrate, api and worker, with a worker stop grace above the attempt deadline. - docs/operations/deployment.md: the image, the example, the explicit stop-migrate-start sequence, and what health checking does and does not cover. - api/health.py: replace the stale "readiness arrives with persistence" comment. No readiness route is added; that is a public-boundary decision left open and documented in Limitations.
/health stays liveness only and no database-checking route is added, so
the public surface remains /health and POST /f/{endpoint_id}. The
deployment page, Limitations and the health handler comment now state
this as a decision rather than an open question.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.