Repository navigation
Make the suite run on Linux - #56
Merged
Merged
Conversation
…rom lying CI ran for the first time and reported 22 failed, 1240 passed on ubuntu-latest against 1260 passed on macOS. This suite had never run on Linux. Two of the three causes were production bugs rather than test problems, and they had never bitten a real run only because the native agent path has never run a real experiment - the archived 170-trial run used the Terminus-2 path. The process-identity snapshot iterated /proc/[0-9]*/stat with no filter on PID 1, while the validator required pid > 1. On Linux /proc/1/stat always exists, so the baseline always failed validation and every test reaching prepare() died. The two halves of one contract disagreed. Nobody noticed because macOS has no /proc: the glob never expanded, the script printed nothing, and both checks passed vacuously on an empty tuple. A platform that could not observe the process table reported exactly what a platform observing zero processes would. That is the sixth instance of the defect this repository catalogues five of in RESULTS.md section 6, and the shape local.py already gets right by typing lingering_processes as int | None. An absent table is now its own status, and the distinction goes one step further than asked: a kernel where the table is structurally unavailable is separated from a reading that failed for some other reason. The first is recorded and the run continues; the second refuses. That split is RESULTS.md section 6's own conclusion - whether the run continues and whether a checkpoint may be restored are different decisions - and the exposure reaches the validation summary as a count, so analysis can exclude affected trials rather than discovering the gap later. The first attempt at this made an unobservable table fatal, which regressed macOS to 3 failures: the old code pretended it was fine, the new code stopped the run, and neither is what the precedent says. Third cause: GNU tar and BSD tar disagree about backslashes in paths, so the implementation is detected rather than assumed. CI now runs the gates on ubuntu-latest and macos-latest, so the next platform gap is caught by CI rather than by someone noticing a red badge. Gates on macOS: pytest 1277 passed / 3 skipped (baseline 1260), ruff check and ruff format --check clean. Linux is what this change exists for and CI is the check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI ran for the first time and reported 22 failed, 1240 passed on
ubuntu-latestagainst 1260 passed on macOS. This suite had never run on Linux, and the README badge said so.Two of the three causes are production bugs, not test problems. They had never bitten a real run only because the native agent path has never run a real experiment — the archived 170-trial run used the Terminus-2 path.
The contract that disagreed with itself
_process_identity_snapshot_script()iterated/proc/[0-9]*/statwith no filter on PID 1, while_valid_process_identity()requiredpid > 1:On Linux
/proc/1/statalways exists — in a container PID 1 always does — so the baseline always failed validation and every test reachingprepare()died. Two halves of one contract, disagreeing.Why three weeks of green runs never caught it
macOS has no
/proc. The glob never expanded, the script printed nothing, and both checks passed vacuously on an empty tuple:any()over()isFalse, andlen(()) != len(set(()))isFalse.A platform that could not observe the process table reported exactly what a platform observing zero processes would. That is the sixth instance of the defect RESULTS.md §6 catalogues five of — and the shape
local.pyalready gets right by typinglingering_processesasint | None.An absent table is now its own status, and the distinction goes one step further than the task asked: a kernel where the table is structurally unavailable is separated from a reading that failed for some other reason. The first is recorded and the run continues; the second refuses.
That split is §6's own conclusion — whether the run continues and whether a checkpoint may be restored are different decisions — and the exposure reaches the validation summary as a count, so analysis can exclude affected trials instead of discovering the gap later.
Third cause
GNU tar and BSD tar disagree about backslashes in paths. The implementation is detected rather than assumed.
CI
Now runs the gates on
ubuntu-latestandmacos-latest, so the next platform gap is caught by CI rather than by someone noticing a red badge.Gates
macOS:
pytest1277 passed, 3 skipped (baseline 1260),ruff checkandruff format --checkclean. Linux is what this change exists for, and CI on this PR is the check that matters.