Repository navigation
Let CI show how many tests ran - #55
Merged
Merged
Conversation
The workflow ran `uv run pytest -q`, but pyproject already sets addopts = "-q", so the second one made it -qq and suppressed the summary line entirely. A CI log that cannot show a test count cannot distinguish a green suite from one that collected nothing and exited 0 - which is the exact failure the test-count gate in CONTRIBUTING exists to catch. The rule was written down and then broken in the place that implements it. Also records a failure that has not been explained. One run on main at 817b96d reported 1 failed, 1259 passed; six later runs were clean and the test name was not captured. It is written down rather than closed, because not reproduced is not does not exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow ran
uv run pytest -q, butpyproject.tomlalready setsaddopts = "-q". The second one makes it-qq, which suppresses the summary line entirely — verified: redirected output ends at the 100% progress line with no count, while dropping the flag prints1260 passed, 3 skipped.A CI log that cannot show a test count cannot distinguish a green suite from one that collected nothing and exited 0 — which is precisely what the test-count gate in CONTRIBUTING.md exists to catch. The rule was written down and then broken in the file that implements it.
Also records, rather than closes, a failure I could not explain: one run on
mainat817b96dreported1 failed, 1259 passed; six subsequent runs were clean and the failing test's name was not captured. Not reproduced is not does not exist.