Conversation
JiwaniZakir
left a comment
There was a problem hiding this comment.
This updates two separate copies of path-to-regexp in package-lock.json: the top-level node_modules/path-to-regexp (0.1.12 → 0.1.13) and a nested copy under node_modules/router/node_modules/path-to-regexp (8.3.0 → 8.4.0). Since only package-lock.json is modified and not package.json, these are transitive dependency bumps — worth confirming whether this was generated via npm audit fix or similar, since it's not obvious from the PR what triggered the change or whether a CVE prompted it.
The presence of the 0.1.x line alongside the 8.x line is worth a second look: the 0.1.x branch is a very old legacy version with known ReDoS vulnerabilities in earlier releases, and having it silently nested in the tree is a latent risk. It would be worth tracing which package pulls in the 0.1.x dependency and checking if that parent dependency can be updated to pull in a modern version instead, rather than continuing to carry this ancient branch.
Finally, it's worth running the test suite after applying this lock file to confirm the router-dependent code paths still behave correctly, since the 8.3.0 → 8.4.0 bump in the router subtree could affect route matching behavior if there were any subtle semantics changes between those releases.
9efaada to
d40373e
Compare
Bumps and [path-to-regexp](https://github.com/pillarjs/path-to-regexp). These dependencies needed to be updated together. Updates `path-to-regexp` from 8.3.0 to 8.4.0 - [Release notes](https://github.com/pillarjs/path-to-regexp/releases) - [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md) - [Commits](pillarjs/path-to-regexp@v8.3.0...v8.4.0) Updates `path-to-regexp` from 0.1.12 to 0.1.13 - [Release notes](https://github.com/pillarjs/path-to-regexp/releases) - [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md) - [Commits](pillarjs/path-to-regexp@v8.3.0...v8.4.0) --- updated-dependencies: - dependency-name: path-to-regexp dependency-version: 8.4.0 dependency-type: indirect - dependency-name: path-to-regexp dependency-version: 0.1.13 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
d40373e to
4fe8076
Compare
Bumps and path-to-regexp. These dependencies needed to be updated together.
Updates
path-to-regexpfrom 8.3.0 to 8.4.0Release notes
Sourced from path-to-regexp's releases.
Commits
34cb4518.4.022a9679Reject large optional route combinations (#424)8881a88Byte optimization (#423)43669acDedupe regex prefixes (#422)4864654Restrict repeated wildcard backtracking (#421)05a5a97Remove dependabot config (#404)5b635cdRemovepackage-lock.json(#407)Updates
path-to-regexpfrom 0.1.12 to 0.1.13Release notes
Sourced from path-to-regexp's releases.
Commits
34cb4518.4.022a9679Reject large optional route combinations (#424)8881a88Byte optimization (#423)43669acDedupe regex prefixes (#422)4864654Restrict repeated wildcard backtracking (#421)05a5a97Remove dependabot config (#404)5b635cdRemovepackage-lock.json(#407)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.