-
Notifications
You must be signed in to change notification settings - Fork 78
feat(worker): add extensible chip-child control dispatch #2116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
superxf
wants to merge
1
commit into
hw-native-sys:main
Choose a base branch
from
superxf:support_mooncake
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+90
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Fix the level guard: level 4+ Workers cannot dispatch
_CTRL_CHIP_EXTENSIONto chip children.At level 3,
WorkerType.NEXT_LEVELchildren are chip processes running_run_chip_main_loop, which has the new_CTRL_CHIP_EXTENSIONbranch. At level 4+,WorkerType.NEXT_LEVELchildren are nestedWorkerinstances running_child_worker_loop, whosehandle_controlhas no_CTRL_CHIP_EXTENSIONcase. Every call on a level >= 4 Worker falls through toraise RuntimeError(f"unknown control sub-command {sub_cmd}")there, sorun_chip_control_extensionalways fails at level 4+.The added line
_CTRL_OP_NAMES[_CTRL_CHIP_EXTENSION] = "chip_extension"confirms this failure path was anticipated (it labels exactly the error_child_worker_loopraises for an unknown command), but the public check still admits level 4+ instead of rejecting it up front.Change the guard to require exactly level 3, or add a
_CTRL_CHIP_EXTENSIONforwarding branch in_child_worker_loopthat recurses into the nested Worker's own chip children.🐛 Proposed fix (restrict to level 3 until recursive forwarding exists)
📝 Committable suggestion
🤖 Prompt for AI Agents