Fix: cap nanobind below 3.0 in the CI setup - #191
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Mirrors pypto-lib#1018. nanobind 3.0.0 (released 2026-08-24) stopped binding a null holder to a parameter typed after a bound class; pypto's TileView uses one for start_offset, so ir.TileView() no longer matches its own all-defaulted overload and every pl.Tile annotation fails to parse — which is every model this repo's guards run. The cap has to live here: the build step passes --no-build-isolation, so the pypto extension compiles against the nanobind this action installs and pypto's own [build-system] requires is never consulted. Cap both pip installs (build step and serving-deps step).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors pypto-lib#1018 hw-native-sys/pypto-lib#1018.
nanobind<3in the build step'spip install, next toscikit-build-core, cmake and ninja.
pip install nanobind transformers …the same way.nanobind 3.0.0, released 2026-08-24, stopped binding a null holder to a parameter
typed after a bound class. pypto's
TileViewuses one forstart_offset, soir.TileView()no longer matches its own all-defaulted overload, and pypto'stype resolver makes that call for every
pl.Tileannotation — every model thisrepo's guards run fails while parsing its first kernel. PyPI already serves
3.0.0 as latest, so any uncapped fresh install takes it: this bites every
unit-testsrun from today, independent of any particular PR (the in-flightrun on #190 is resolving 3.0.0 right now).
The cap has to live in this repository: the build step passes
--no-build-isolation, so the pypto extension is compiled against the nanobindthis action installs and pypto's own
[build-system]requires (capped byhw-native-sys/pypto#2492) is never consulted. Raise it alongside pypto-lib once
nanobind 3.x compatibility lands upstream; hw-native-sys/pypto#2493 tracks the
wider problem that these build inputs are unbounded.