Refactor: follow pypto-lib's flattened model directories - #136
Merged
superxf merged 1 commit intoAug 5, 2026
Merged
Conversation
📝 WalkthroughWalkthroughDeepSeekV4 and Qwen3-14B kernel discovery now targets flattened model directories. Module detection and related test fixtures use the same paths. ChangesKernel path migration
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
zhangqi-chen
force-pushed
the
refactor/pypto-lib-flat-model-dirs
branch
2 times, most recently
from
August 4, 2026 16:08
6ce7078 to
2e6fbd9
Compare
pypto-lib replaced models/<family>/<variant>/ with one flat directory per model build, so the hardcoded kernel paths here no longer resolve. - Bump the pypto-lib submodule to the revision that carries the rename. - Qwen3-14B resolves models/qwen3_14b instead of models/qwen3/14b, in both the PYPTO_ROOT branch and the checkout walk. - DeepSeekV4 resolves models/deepseek_v4_flash_mtp instead of models/deepseek/v4-flash. Two places assumed the extra family level: _is_deepseek_v4_module_file compared three trailing path segments, and _load_kernel_modules derived the pypto-lib root it puts on sys.path as _kernel_dir.parents[2]. Both now count one level less. - Retarget the kernel-directory constants in the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pypto-lib replaced models/// with one flat directory per
model build, so the hardcoded kernel paths here no longer resolve.
the PYPTO_ROOT branch and the checkout walk.
models/deepseek/v4-flash. Two places assumed the extra family level:
_is_deepseek_v4_module_file compared three trailing path segments, and
_load_kernel_modules derived the pypto-lib root it puts on sys.path as
_kernel_dir.parents[2]. Both now count one level less.