Clarify Agent Merge notice scope and use On/Off for the session merge choice - #1
Open
huyn7539 wants to merge 3 commits into
Open
Clarify Agent Merge notice scope and use On/Off for the session merge choice#1huyn7539 wants to merge 3 commits into
huyn7539 wants to merge 3 commits into
Conversation
Co-authored-by: benibenj <44439583+benibenj@users.noreply.github.com>
Claim check for #1 — 7 of 9 claims checked · 7 presentClaims vs diff (9)
Attention (3)
Author attestation — draft, confirm or editWhat changed: Confirm attestation in Antelier After confirmation, each answer is checked against the same diff as the PR claims. Rules applied (2) · Provenance · Not read (6 lines)
Rule version Generated by Antelier. Every citation resolves to diff bytes; no human has reviewed these results. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two wording changes to Agent Merge:
Agent Merge settings changed.regardless of whether the change was made for that one session or to the defaults every session follows.Always/Never, absolutes that only hold for the setting, which applies across all sessions.Notices name the scope
agentMergeConfigurationChangedNoticenow takes a required scope and heads the notice accordingly:AgentMergeControllerderives the scope by comparing the session overrides that produced the last announcement with the current ones — a per-session change is exactly what writes overrides, so anything else that moved the effective configuration came from the defaults. Deriving it in one place rather than passing it from each call site also attributes changes that land while a session's runtime is stopped, which the existingannounces effective session and global configuration changes while monitoringtest exercises.To support that,
_announcedConfigurationsrecords the overrides alongside the configuration it resolved from.Session merge choice says On/Off
On/Off;Only if Agent Merge Made No Changesis unchanged, and its description now says it "switches itself off".always/ifUnchanged/never, unchanged in the settings editor.Tests and fixtures
agentMerge.test.tsandagentMergeController.test.ts; the controller test now distinguishes the session heading from the global one.DefaultsChangedcomponent fixture beside the existingConfigurationChangedone so both headings render.