Prevent infinite loop in unstable AST JSDoc scanner

[huyn7539]

Replay of microsoft#64141 (agent PR, head cba9b6b) on a fork, to test Antelier against a real large repo. Nothing here is proposed for upstream.

The unstable AST JSDoc scanner could loop indefinitely when a scan range ended immediately after -, because the range check did not guard the full identifier condition.

Changes

• Guard both identifier parts and hyphens with pos < end:

while (pos < end && (isIdentifierPart(...) || char === CharacterCodes.minus))

• Add regression coverage verifying that a range ending in x- reaches EOF and preserves the expected tokens.

• Fixes unstable/ast: scanJsDocToken infinite-loops when a scan range ends on a trailing '-' (fix from #63581 not carried into the AST scanner) microsoft/TypeScript#64135

[github-actions]

Claim check for #1 — 2 of 5 claims checked · 2 present

Claims vs diff (5)

#	Claim (quoted from the PR)	Label	Evidence
1	Guard both identifier parts and hyphens with pos < end: …/ast/scanner.ts @@ -2434,7 +2434,7 @@ L2437	present	identifier appears in the expected changed hunk lines
2	Add regression coverage verifying that a range ending in x- reaches EOF and preserves the expected tokens. …/test/scanner.test.ts @@ -0,0 +1,23 @@ L1	present	test file is present in the PR file list
—	3 not checkable (show) Prevent infinite loop in unstable AST JSDoc scanner — not checked (judged tier off) Fix AST JSDoc scan range handling — not checked (judged tier off) Format AST scanner regression test — not checked (judged tier off)	not checkable	collapsed by default
—	1 context line (not claims, show) The unstable AST JSDoc scanner could loop indefinitely when a scan range ended immediately after -, because the range check did not guard the full identifier condition. — context: describes state or cause, not a change this PR makes	context	describes state or cause; never labelled

Attention (2)

1. undisclosed-file — File changed but not mentioned in the PR body — packages/typescript/test/scanner.test.ts — packages/typescript/test/scanner.test.ts @@ -0,0 +1,23 @@ L1-L23
2. ci-reported — CI — reported build: QUEUED, claim-check: IN_PROGRESS, extension: QUEUED, package-feed-proxy: QUEUED, go-test: QUEUED, test (ubuntu-latest): QUEUED, test (windows-latest): IN_PROGRESS, test (noembed): QUEUED, test (concurrent test programs): QUEUED, test extra (ubuntu-latest): QUEUED, test extra (windows-latest): IN_PROGRESS, lint (ubuntu-latest): QUEUED, lint (windows-latest): QUEUED, lint (noembed): QUEUED, format: QUEUED, generate: QUEUED, tidy: IN_PROGRESS, smoke: QUEUED, misc: QUEUED; reported, not observed by Work Loop — packages/typescript/test/scanner.test.ts @@ -0,0 +1,23 @@ L1-L23

Author attestation — draft, confirm or edit

What changed: Guard both identifier parts and hyphens with pos < end: — packages/typescript/src/ast/scanner.ts @@ -2434,7 +2434,7 @@ L2437
Why: Why this change was made is not established by the excluded motivation text; confirm intent. — packages/typescript/src/ast/scanner.ts @@ -2434,7 +2434,7 @@ L2437
What could break: Callers of the touched export createScanner could break; confirm its compatibility at this diff. — packages/typescript/src/ast/scanner.ts @@ -2434,7 +2434,7 @@ L2437
What was tested: Add regression coverage verifying that a range ending in x- reaches EOF and preserves the expected tokens. — packages/typescript/test/scanner.test.ts @@ -0,0 +1,23 @@ L1

Confirm attestation in Antelier

After confirmation, each answer is checked against the same diff as the PR claims.

Rules applied (2) · Provenance · Not read (21 lines)

• Rule: Claim labels use fetched patch bytes only
• Rule: Citations are verified before rendering
  Provenance: human login huyn7539; Co-authored-by jakebailey → agent-assisted (reported)
• Not read: > Replay of Prevent infinite loop in unstable AST JSDoc scanner microsoft/TypeScript#64141 (agent PR, head cba9b6b) on a fork, to test Antelier against a real large repo. Nothing here is proposed for upstream.
• Not read: <!--
• Not read: Thank you for submitting a pull request!
• Not read: Please verify that:
• Not read: * [ ] There is an associated issue in the Backlog milestone (required)
• Not read: * [ ] Code is up-to-date with the main branch
• Not read: * [ ] You've successfully run npx hereby test
• Not read: * [ ] You've successfully run npx hereby lint
• Not read: * [ ] You've successfully run npx hereby check:format
• Not read: * [ ] There are new or updated tests validating the change
• Not read: Refer to CONTRIBUTING.md for more details:
• Not read: https://github.com/Microsoft/TypeScript/blob/main/CONTRIBUTING.md
• Not read: Please don't send a PR solely to fix a typo unless it materially improves
• Not read: understanding. Each PR represents review and maintenance work.
• Not read: -->
• Not read: while (pos < end && (isIdentifierPart(...) || char === CharacterCodes.minus))
• Not read:
• Not read: - Fixes unstable/ast: scanJsDocToken infinite-loops when a scan range ends on a trailing '-' (fix from #63581 not carried into the AST scanner) microsoft/TypeScript#64135
• Not read: Initial plan
• Not read: retrigger Antelier v1.1.0
• Not read: retrigger Antelier v1.1.0

Rule version claim-check-rubric-v1 · JSON route /api/truth/v1/pr/1

Generated by Antelier. Every citation resolves to diff bytes; no human has reviewed these results.