Repository navigation
Tests: replace absolute throughput floors in concurrency tests with an overlap proof - #59
Merged
Merged
Conversation
…n overlap proof IvfConcurrencyTest required more than 1000 reads in 5 s, which failed on a slow GitHub-hosted Windows runner (249 reads). The test is about correctness under concurrency, so it now requires writes > 100 and reads > 50 (plus the existing retrain check). ApplyStressTest had the same pattern (500 floors) and drops to 50. Closes #58 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #58
I replaced the absolute throughput floor in
IvfConcurrencyTestwith a proof that writers and readers overlapped.IvfConcurrencyTest(IvfConcurrencyShortTest,IvfConcurrencyLongTest,ScalarTwinIvfConcurrencyTest)writes > 1000 && reads > 1000writes > 100 && reads > 50, plus the existingretrains >= 1ApplyStressTestbatches >= 500,searches >= 500batches >= 50,searches >= 50The run length stays time-based and no correctness check is weakened (result equality, zero errors, last-100-inserts, size and list sizes, every id found by its own vector). The failing Windows run had 249 reads in 5 s, so the old floor measured the speed of the runner, not correctness under concurrency. The other concurrency tests (
FlatConcurrencyTest,GraphConcurrencyTest,TierTests) have no absolute throughput floor.Nothing ran locally (no java or mvn on this laptop); CI runs the tests.
🤖 Generated with Claude Code