Repository navigation
CI: make the Windows x64 jobs regular jobs - #55
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54
I removed
continue-on-error: truefromfast-windowsinci.ymland fromsmoke-windows-vectorinnative-image.yml, and removed the YAML comments and the text inREADME.mdanddocs/STATUS.mdthat called the two Windows jobs an experiment or said they may fail without blocking. The comments that explain real Windows specifics stay (shell: bash, the;class path separator,.exe,native-image.cmd,timeout-minutes).The docs now state what the Windows jobs run: the fast tests (not the slow tests) and the vector native image smoke (no scalar image job on Windows).
This changes no required check: the job names are unchanged and neither job is required. If a Windows job fails later, it shows red and the merge rule (every check green) applies, which is intended. A failure of the GitHub Windows image or the GraalVM download can be unrelated to the code, so a rerun handles it.
I checked that both YAML files parse and that
git diff --checkis clean. I did not run Java.🤖 Generated with Claude Code