Remove OAuth2 well-known discovery endpoints - #42
Open
roborourke wants to merge 1 commit into
Open
roborourke wants to merge 1 commit into
roborourke wants to merge 1 commit into
Conversation
The OAuth2 authorization-server metadata (RFC 8414) and protected- resource metadata (RFC 9728) discovery endpoints, served at /.well-known/oauth-authorization-server and /.well-known/oauth-protected-resource, don't fit well as a standalone feature of this plugin. Equivalent functionality is being upstreamed into WP-API/OAuth2 instead, where it belongs alongside the rest of the OAuth2 server implementation. This drops the discovery code, its filters (hm_oauth2_discovery_metadata, hm_oauth2_protected_resource_metadata), its mention in the hm_rest_ability_login_wall_exemptions filter docs, and its tests. The now-moot "serve .well-known with trailing slash" Unreleased changelog entry is replaced with a Removed entry pointing at the upstream project. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Playwright test results
Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This removes the OAuth2 discovery endpoints from the plugin:
/.well-known/oauth-authorization-serverand/.well-known/oauth-protected-resource. They don't fit well as a standalone feature here.The same functionality is being upstreamed into WP-API/OAuth2 instead, next to the rest of the OAuth2 server code.
Removed:
inc/oauth2-discovery.phpand its testshm_oauth2_discovery_metadataandhm_oauth2_protected_resource_metadatafilters, and their README docshm_rest_ability_login_wall_exemptionsfilter docsTesting instructions
composer lintandcomposer testpassnpm run test:e2epasses (if this touches plugin behaviour)CHANGELOG.mdupdated under[Unreleased]🤖 Generated with Claude Code