Release 0.8.21-beta1: Add agents support in SDK #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
143
to
145
| process.stderr.write( | ||
| `\n${RED}Received signal ${signum}, cancelling Evaluation and shutting down threads...${RESET}\n`, | ||
| `\n${RED}Received signal ${signum}, cancelling the Evaluation...${RESET}\n`, | ||
| ); |
Contributor
There was a problem hiding this comment.
(non-blocking) would love helpers for this like you did in python
Comment on lines
-470
to
-474
| } else { | ||
| // TODO: trigger run when updated API is available | ||
| console.log( | ||
| `${CYAN}\nRunning ${hlFile.name} over the Dataset ${hlDataset.name}${RESET}`, | ||
| ); |
Contributor
There was a problem hiding this comment.
is this a functional change?
Comment on lines
+493
to
+495
| console.warn( | ||
| `${YELLOW}No \`file\` type specified, defaulting to flow.${RESET}\n`, | ||
| ); |
Contributor
There was a problem hiding this comment.
Do we need this in line 484 as well?
Contributor
There was a problem hiding this comment.
not sure what would error in the try/catch
Comment on lines
-592
to
-594
| case "evaluator": | ||
| hlFile = await client.evaluators.upsert(fileDict as EvaluatorRequest); | ||
| break; |
Contributor
There was a problem hiding this comment.
same q as python -- intentional?
| const fileDict = { ...fileConfig, ...version }; | ||
| const type = fileConfig.type; | ||
|
|
||
| let hlFile: PromptResponse | FlowResponse | ToolResponse | EvaluatorResponse; |
Contributor
There was a problem hiding this comment.
same q as python -- no agent?
jamesbaskerville
approved these changes
Apr 28, 2025
Contributor
jamesbaskerville
left a comment
jamesbaskerville
left a comment
There was a problem hiding this comment.
nothing blocking -- same questions as python mostly.
andreibratu
force-pushed
the
add-agents
branch
3 times, most recently
from
e8cc087 to
ba6d2f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.