Skip to content

test: fail on lint warnings and strengthen coverage - #154

Merged
KidkArolis merged 1 commit into
masterfrom
codex/test-coverage-and-strict-lint
Sep 30, 2026
Merged

KidkArolis merged 1 commit into
masterfrom
codex/test-coverage-and-strict-lint

Conversation

@KidkArolis

Copy link
Copy Markdown
Collaborator

Lint warnings previously passed CI, and the public loading helpers and devtools cache editor had no behavioral coverage. Make npm run lint reject warnings and have npm test use the same command.

Add tests for spinner delays and minimum visibility, debouncing and Suspense transitions, and cache editing with ID validation, query membership updates, undo, and no server requests. Initialize JSDOM before React DOM so input events work in the test harness. Replace weak runtime type tests with compiler assertions, remove a dated schema smoke test, and combine six descriptor-read tests into two.

Validation:

  • npm run tsc, npm run lint, npm run ava, and npm test pass, including formatting and 439 tests.
  • Line coverage increases from 88.71% to 91.39%, with one fewer test overall. Cache tab coverage increases from 8.35% to 86.39%.
  • Confirmed the original lint warnings fail with --deny-warnings. Temporarily removing the transition or cache ID guard causes the corresponding new test to fail; restored both and reran the tests.
  • Local test runs use SWC_NATIVE_BINDING_CACHE=/private/tmp/figbird-swc-native-cache to keep the native cache within the sandbox.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: low. Approved based on a passing Cursor Bugbot check with no findings (Security Agent was not running) and CI tests succeeding. No reviewers were assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver - Risk Based

@KidkArolis
KidkArolis merged commit 088653c into master Sep 30, 2026
5 checks passed
@KidkArolis
KidkArolis deleted the codex/test-coverage-and-strict-lint branch September 30, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant