Repository navigation
test: fail on lint warnings and strengthen coverage - #154
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Lint warnings previously passed CI, and the public loading helpers and devtools cache editor had no behavioral coverage. Make
npm run lintreject warnings and havenpm testuse the same command.Add tests for spinner delays and minimum visibility, debouncing and Suspense transitions, and cache editing with ID validation, query membership updates, undo, and no server requests. Initialize JSDOM before React DOM so input events work in the test harness. Replace weak runtime type tests with compiler assertions, remove a dated schema smoke test, and combine six descriptor-read tests into two.
Validation:
npm run tsc,npm run lint,npm run ava, andnpm testpass, including formatting and 439 tests.--deny-warnings. Temporarily removing the transition or cache ID guard causes the corresponding new test to fail; restored both and reran the tests.SWC_NATIVE_BINDING_CACHE=/private/tmp/figbird-swc-native-cacheto keep the native cache within the sandbox.