Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build_pr_documentation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ concurrency:
jobs:
build:
if: github.event.pull_request.draft == false
uses: huggingface/doc-builder/.github/workflows/build_pr_documentation.yml@cf20b09f274383f0d91a7055c5e43f0a2ab3d1a3 # main
uses: huggingface/doc-builder/.github/workflows/build_pr_documentation.yml@9f9bb430a712b5650d0e43e510656098ecdd75d4 # main

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this bump: cf20b09f → 9f9bb430 is a clean forward bump (ahead 3 / behind 0) and 9f9bb430 == doc-builder main tip, so # main is accurate.

No break: the reusable workflow's workflow_call required inputs are unchanged (commit_sha, pr_number, package) and there's no secrets: block — this caller supplies all required inputs (version_tag_suffix is optional). doc_builder_revision dropped its default: "main" and now defaults to the caller's pinned SHA (job.workflow_sha); OpenEnv doesn't pass it, so behavior is unchanged.

Security-positive: the new revision pins the doc-builder checkout to the caller's pinned SHA instead of floating main, adds permissions: {} + job contents: read, sets persist-credentials: false, and moves inputs into env: vars (script-injection hardening).

with:
commit_sha: ${{ github.event.pull_request.head.sha }}
pr_number: ${{ github.event.number }}
Expand Down
Loading