Bump mlx-swift-lm to 3.x (3.31.3)#161
Open
noorbhatia wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #157
mlx-swift-lm 3.x decouples MLXLMCommon from the Hugging Face Hub and
swift-transformers' tokenizer: it now defines its own Tokenizer,
Downloader, and TokenizerLoader protocols, and consumers must supply
concrete implementations. Adopt the in-repo MLXHuggingFace macros to
restore Hub-based loading with minimal churn, keeping the existing
ModelContext-based backend intact.
Package.swift:
0.31.x).
(HubClient), and swift-transformers' Tokenizers (AutoTokenizer).
MLXLanguageModel.swift:
import Hub; add MLXLLM, MLXHuggingFace, HuggingFace imports.MLXLLM is now imported so MLXLLM.TrampolineModelFactory is linked
alongside MLXVLM's for ModelFactoryRegistry resolution.
the 3.x loadModel(from:using:id:) / loadModel(from:using:), expanding
the #hubDownloader() and #huggingFaceTokenizerLoader() macros.
qualify
any Tokenizer->any MLXLMCommon.Tokenizerto disambiguatefrom Tokenizers.Tokenizer.
BREAKING (MLX trait only): MLXLanguageModel.hub and its
hub:initparameter change from HubApi? to HubClient?. Code passing or reading a
custom hub must switch
import Hub+ HubApi(...) toimport HuggingFaceconstructions are unaffected; non-MLX consumers see no change.