-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade zipp from 3.15.0 to 3.19.1 #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…lnerabilities The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-ZIPP-7430899
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, addresses a security vulnerability by upgrading the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request from Snyk correctly addresses a security vulnerability by pinning the zipp dependency to version 3.19.1 or newer. This is a valuable and necessary change. My review includes a comment on the requirements.txt file, highlighting that while this fix is good, there are other missing dependencies noted in the Snyk report that should be addressed to ensure the example is runnable. I've provided a suggestion on how to fix the requirements.txt file to make the example fully functional.
|
|
||
| ultralytics | ||
| transformers | ||
| zipp>=3.19.1 # not directly required, pinned by Snyk to avoid a vulnerability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While pinning zipp is correct for fixing the security vulnerability, the Snyk warnings in the PR description indicate that this requirements.txt file is incomplete. Specifically, scipy and safetensors are missing, and there is a numpy version conflict. These issues will likely prevent the example from running correctly for users setting up a new environment.
To ensure the example is runnable out-of-the-box, please consider adding the missing dependencies. A more complete requirements.txt would look like this:
ultralytics
transformers
scipy
safetensors
numpy>=1.22.2
zipp>=3.19.1
Since this is an automated PR, addressing this in a follow-up is understandable, but it's an important fix for the usability of this example.
…lnerabilities The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-ZIPP-7430899
Snyk has created this PR to fix 1 vulnerabilities in the pip dependencies of this project.
Snyk changed the following file(s):
examples/YOLOv8-Action-Recognition/requirements.txtImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.