Skip to content

Fixes #1972: Add tests for automatic request compression with single --compress flag #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vinayK34 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes #1972: Add tests for automatic request compression with single --compress flag #1991

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions tests/test_compress.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,3 +138,31 @@ def test_compress_file(httpbin_both):
'multipart/form-data; boundary=')
assert r.json['files'] == {}
assert FILE_CONTENT not in r


def test_compress_json_normal(httpbin_both):
# Test normal compression with one --compress flag where compression
# reduces size (should compress)
r = http(
'--compress',
httpbin_both + '/post',
'foo=bar',
)
assert HTTP_OK in r
assert r.json['headers']['Content-Encoding'] == 'deflate'

@OKAN-SOFTWARE OKAN-SOFTWARE Oct 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this new test conflicts with test_compress_skip_negative_ratio() earlier in the same file.

Both tests send the same small JSON payload (foo=bar) with a single --compress flag.

The existing test correctly expects no Content-Encoding header because compressing such a small payload increases its size. This new test expects deflate for the identical request, so the two assertions cannot both pass.

Could we use a larger, repetitive JSON payload here to make compression beneficial?

That would let this test cover the intended positive-compression case while preserving the existing negative-ratio behavior.

assert_decompressed_equal(r.json['data'], '{"foo": "bar"}')
assert r.json['json'] is None


def test_compress_raw_normal(httpbin_both):
# Test normal compression with one --compress flag where compression
# reduces size (should compress)
r = http(
'--raw',
FILE_CONTENT,
'--compress',
httpbin_both + '/post',
)
assert HTTP_OK in r
assert r.json['headers']['Content-Encoding'] == 'deflate'
assert_decompressed_equal(r.json['data'], FILE_CONTENT.strip())
Loading