Skip to content

fix: adjust lazy_choices test for Python 3.14+ argparse changes #1875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
decembercomposer697-hue wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: adjust lazy_choices test for Python 3.14+ argparse changes #1875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3cba82d
fix: adjust lazy_choices test for Python 3.14+ argparse changes
decembercomposer697-hue Jun 18, 2026
52b6456
Fix unused import that caused CI failure
Jun 19, 2026
d119f20
fix: make LazyChoices.help truly lazy to fix cross-version compatibility
Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions httpie/cli/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,7 @@ def load(self) -> T:
return self._obj

@property
def help(self) -> str:
if self._help is None and self.help_formatter is not None:
self._help = self.help_formatter(
self.load(),
isolation_mode=self.isolation_mode
)
def help(self) -> str | None:
return self._help

@help.setter
Expand Down
2 changes: 2 additions & 0 deletions tests/test_cli_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ def test_lazy_choices_help():
getter = mock.getter
getter.return_value = ['a', 'b', 'c']

# Help formatter is only called when --help is used (lazy)

help_formatter = mock.help_formatter
help_formatter.return_value = '<my help>'

Expand Down
Loading