Fix loading states - #22
Merged
Merged
Conversation
The shell opens in 0.11s and then reads the venues behind it — 5 to 9 seconds for a wallet across nine chains. For that whole window the status line said `0 positions` and the `/` menu said `0 tokens`. Not blank: zero, about an account nobody had answered for yet. `isLoaded` was the wrong question. It says a load finished, not which venues it was built from, so a venue connected after the shell opened fell straight through it — the store held it at once, the book did not. `covers()` and `coversAll()` ask the answerable question, and the venue list they take is the build's, not the store's: a venue tula dropped is skipped before `refresh` records it, so asking about the store could never come true and `/shock` went dark for the rest of the session with a `/refresh` that could not fix it. `reading…` and `not read` are different claims, so the session carries the third state rather than the UI guessing: a refresh that threw was a spinner over nothing, with no command offered. The busy row counts its parts — `reading wallet · 4 of 9 chains` — because one unchanging label is what a hang looks like. A chain that failed still counts: the reader is no longer waiting for it. The count is caught at the session boundary, since a promise derived from `.finally()` rejects when the callback throws, and a UI listener must not be able to delete a chain's positions and blame the node that answered. Also: the model is never handed the epoch as a book's `fetched_at`; Aave's stable-rate gap is retired with the live check `breadth/09` requires for a retirement; and `/kraken`'s meta description catches up with its own page. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The rows were raised to 44px for a tap target, against the reasoning already written above the constant: a 32px row keeps each target above WCAG 2.2's 24px minimum, and stacked links cannot borrow target from the space around them without handing their taps to the next. At 44px the space between links read the same as the space to the section heading, so Pages, Guides and More links stopped looking like headings over lists. The comment was left saying 32 while the code said 44, which is the drift the comment rule exists to prevent. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.