Fix Windows orchestration and release checks for 1.7.0 - #102
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows release packaging exposed failures that the previous Windows PR job did not run. This follow-up to #101 fixes orchestration startup on Windows by reusing the existing current-user-only native pipe host, recognizes private Windows paths both directly and inside command options, and stops environment wrappers from appending a second extension to names such as
node.exe.The Git worktree example now resolves both Git's repository path and the terminal's folder through the native filesystem API before calculating their relative path, preserving nested folders when Windows exposes short paths such as
RUNNER~1.The affected tests now use native file URLs, available executables, native shell quoting, and portable line-ending/path expectations. A launch test shuts down its manager before deleting its persistence directory. Orchestration tests exercise the secured native pipe on Windows. No failing test is disabled. The Windows PR job now runs the full suite, so these failures are caught before tagging a release.
Validation: local TypeScript checks and all 142 affected tests passed; the 21 tests covering path/executable refinements and the latest 27 environment/launch tests also passed. Complete Linux/Windows/macOS CI results are checked before merge. The application version remains 1.7.0; the first release attempt did not publish a GitHub release.