Repository navigation
feat(editor): show the snap target's size next to the loupe coordinates - #9
Merged
Merged
Conversation
While a snap frame is highlighted, the loupe's coordinate row also shows the target's width and height in native pixels: the hovered element or window, or the whole display for a crop over bare desktop. The loupe flips to the left of the pointer early enough that the row stays on screen.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
While aiming with a snap tool, the highlighted frame showed which element or window a click would take, but not its size. The width and height appeared only after a drag had started.
Change
lib/editor/editor_core.dart: the loupe's coordinate row gains a second pill with the snap target's width and height in native pixels, to the right of the coordinates. It shows whenever a snap frame is highlighted: the hovered element or window, or the whole display for a crop over bare desktop. It hides with the loupe's info blocks, and during a drag the existing drag readout takes over.test/editor/editor_core_snap_test.dart: cases for the size shown per target, the whole-display size, the row order and position, the right edge, a tool without snap, and a drag.Verification
flutter analyzeand the fullflutter testsuite pass on macOS.