Repository navigation
ci(release): set the app icon as the macOS DMG volume icon - #6
Merged
Merged
Conversation
The mounted disk image showed the generic disk icon on the desktop and in Finder. create-dmg's --volicon places .VolumeIcon.icns at the volume root and sets the custom-icon attribute; the AppIcon.icns that flutter build already writes into the app bundle is reused, so no new asset is needed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
The mounted macOS disk image shows the generic disk icon on the desktop and in Finder. The release workflow builds the DMG with create-dmg but never sets a volume icon, so the volume root has no
.VolumeIcon.icnsand no custom-icon attribute.Change
.github/workflows/release.yml: add--voliconto the create-dmg call, pointing at theAppIcon.icnsthatflutter build macosalready writes into the app bundle. No new asset. The hdiutil fallback path is unchanged.Verification
.VolumeIcon.icns(byte-identical to the bundle'sAppIcon.icns) and the custom-icon attribute, and Finder resolves the volume icon to the app icon.