fix(timeobjects): skip missing optional drivers without error spam#2
Merged
ralflang merged 1 commit intoJul 21, 2026
Merged
Conversation
Weather and FacebookEvents depend on Composer suggest packages. When those are not installed, listTimeObjectCategories now skips them quietly instead of logging an error on every category probe.
ralflang
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Horde_Service_Weather/Horde_Service_Facebookis treated as a normal skip during category discovery.Motivation
After the PSR-3 logger wiring, every calendar/category probe logged:
TimeObjects driver "Weather|FacebookEvents" failed to initialize: … is not installedwhen those suggest packages were absent (and conf already disables them). That is expected, not a failure.
Changes
listTimeObjectCategories()checksclass_exists()for each driver’s required service class and continues without logging when absent.Test plan
horde/service_weather/horde/service_facebookinstalled, open Kronolith (or any UI that lists time object categories) and confirm/tmp-horde/horde.logno longer gets the “is not installed” errors.ensure()succeeds.