fix: prepare for 6.0.0 stable release#13
Merged
Conversation
PHP 8 rejects unparenthesized `a ? b : c ? d : e`. Add explicit parens on the inner branch in _decode() and _encode() so the file parses.
php-cs-fixer rewrite across 33 files and .horde.yml: array() => [], list() => [], trailing commas, copyright bumps, compact YAML authors form, added keywords field. No logic changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two changes surfaced by
horde-components qcon FRAMEWORK_6_0 ahead of the 6.0.0 stable cut:lib/Driver/Pine.phphad three nested ternaries ina ? b : c ? d : eform. PHP 8 rejects this — the file failed to parse. Added parens on the inner branch.horde-components qc --fix-qc-issues. php-cs-fixer rewrote 33 files (array()/list()→ short-array syntax, trailing commas, copyright bumps);.horde.ymlreflowed to compact authors form andkeywords:field added. No logic changes.