refactor(responsive): use ResponsiveChromeRenderer, consolidate CSS#12
Merged
Conversation
The horde-installer-plugin requires a themes directory to be recognized during reconfigure. Without screen.css, the passwd theme was not symlinked to the web directory.
Migrate controller to use ResponsiveChromeRenderer with body-only template. Delete old full-page template and standalone CSS files. Responsive rules now live in screen.css under .horde-responsive scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResponsiveChromeRendererwith a body-only template instead of manually assembling full HTML pagesresponsive.css,passwd-responsive.css)screen.cssunder.horde-responsivescope, discovered viaCascadeCssDiscovererTest plan
/passwd/responsiveand verify the password change form renders correctly/default/)