fix(activesync): skip GAL contacts calls when Turba is absent#202
Open
TDannhauer wants to merge 1 commit into
Open
fix(activesync): skip GAL contacts calls when Turba is absent#202TDannhauer wants to merge 1 commit into
TDannhauer wants to merge 1 commit into
Conversation
IMP advertises contacts/favouriteRecipients, so listAPIs() includes "contacts" even without a full contacts provider. Guard getGalUid, search, and ResolveRecipients so mail-only ActiveSync installs do not throw Horde_Exception.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contacts/getGalUid(and related contacts APIs) when no contacts provider such as Turba is installed.Motivation
On mail-only Horde installs, IMP still registers
contacts/favouriteRecipients. That makes$registry->contactssucceed vialistAPIs(), butcontacts/getGalUidis not registered. ActiveSync then logs:The method "contacts/getGalUid" is not defined in the Horde Registry.This can happen even when the client has contacts sync disabled (e.g. Gmail), because ResolveRecipients / GAL helpers still probe the GAL.
Changes
contacts_getGal(): checkhasMethod('contacts/getGalUid')before calling; cache withisset.contacts_search()/resolveRecipient(): return empty results whenhasInterface('contacts')is false.ConnectorContactsGetGalTest.Test plan
ConnectorContactsGetGalTestcontacts/getGalUidERR in logs